You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Severity: Low
Fix causality; This issue should be fixed after #6
Background
The flag mine in a given block is used to know whether the current participant has authored the block.
This is useful since only the author of a block is authorized to prepend and append it.
Problem
This information is stored in the JSON representation of a block. It is used by other participants to recover the document.
This flag is potentially wrong since the participant is not necessarily the same. As a fix, this property is not used when the block is recovered. Instead the flag is always sets to false.
However this quick fix doesn't enable to a participant that authored a block in a previous session to extend it in the new session.
Possible fix
Replace the flag by a query function that tests if the block is authored by the current participant or not. This is possible by retrieving the participant identifier from the block's id and comparing this with the current participant's identifier.
The function isMine is already wrote in idfactory.ts.
The function could be passed during each block instantiation. To simplify this passing, we could use a factory method.
The text was updated successfully, but these errors were encountered:
Severity: Low
Fix causality; This issue should be fixed after #6
Background
The flag
mine
in a given block is used to know whether the current participant has authored the block.This is useful since only the author of a block is authorized to prepend and append it.
Problem
This information is stored in the JSON representation of a block. It is used by other participants to recover the document.
This flag is potentially wrong since the participant is not necessarily the same. As a fix, this property is not used when the block is recovered. Instead the flag is always sets to false.
However this quick fix doesn't enable to a participant that authored a block in a previous session to extend it in the new session.
Possible fix
Replace the flag by a query function that tests if the block is authored by the current participant or not. This is possible by retrieving the participant identifier from the block's id and comparing this with the current participant's identifier.
The function
isMine
is already wrote inidfactory.ts
.The function could be passed during each block instantiation. To simplify this passing, we could use a factory method.
The text was updated successfully, but these errors were encountered: