Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 'create file' button #103

Open
MahmoudHamdy02 opened this issue Aug 30, 2023 · 2 comments · May be fixed by #106
Open

add 'create file' button #103

MahmoudHamdy02 opened this issue Aug 30, 2023 · 2 comments · May be fixed by #106
Labels
enhancement New feature or request

Comments

@MahmoudHamdy02
Copy link
Collaborator

No description provided.

@MahmoudHamdy02 MahmoudHamdy02 linked a pull request Sep 1, 2023 that will close this issue
@KKoukiou
Copy link
Collaborator

KKoukiou commented Sep 4, 2023

I am not convinced this is a desired feature. A plain empty file (created with 'touch') as in the linked PR is of not much use case. I would delay this till we have a text editor merged.

@KKoukiou KKoukiou added the blocked Don't land until something else happens first (see task list) label Sep 4, 2023
@jelly jelly added enhancement New feature or request and removed blocked Don't land until something else happens first (see task list) labels Sep 4, 2024
@jelly
Copy link
Member

jelly commented Sep 4, 2024

Creating a new file can be implemented now that we have a basic editor.

Some issues we need to tackle to implement this is the file permissions for the new file. The most logical implementation to me is to re-use "create directory" file ownership selector when creating a new file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants