Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Health card design-related issues #20822

Open
garrett opened this issue Jul 31, 2024 · 4 comments · May be fixed by #21044
Open

Health card design-related issues #20822

garrett opened this issue Jul 31, 2024 · 4 comments · May be fixed by #21044
Labels
bug good-first-issue Appropriate for new contributors

Comments

@garrett
Copy link
Member

garrett commented Jul 31, 2024 •
edited
Loading

The health card has several implementation issues that are not to spec:

image

It's inconsistently spaced between items
The software update message should be a header with details, not just a string
The font size of the login detail info should be smaller
@garrett garrett changed the title Health card designissues Health card design-related issues Jul 31, 2024
@garrett garrett added the bug label Jul 31, 2024
@garrett
Copy link
Member Author

garrett commented Jul 31, 2024 •
edited
Loading

Another screenshot, from mvo's recent video:

image

@martinpitt martinpitt added good-first-issue Appropriate for new contributors has-design and removed has-design labels Aug 21, 2024
@Spoorthy1423
Copy link

Hey!! @garrett i would like to work on this issue, can u please assign me this issue??

@garrett
Copy link
Member Author

garrett commented Sep 2, 2024

@Spoorthy1423: Issues don't need to be assigned to someone before people work on them. If you want to work on this, go ahead and send up a PR. Thanks!

@garrett
Copy link
Member Author

garrett commented Sep 2, 2024

Here's a mockup with uniform spacing:

Health card(3)

And inspecting to show the spacing:

image

image

@ashley-cui ashley-cui linked a pull request Sep 27, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug good-first-issue Appropriate for new contributors
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Standardize healthcard CSS ashley-cui/cockpit
3 participants
@garrett @martinpitt @Spoorthy1423