Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closing cockpit-bridge-connector.pyz shows a "reconnect" button which won't work #76

Open
jelly opened this issue Oct 25, 2022 · 1 comment

Comments

@jelly
Copy link
Member

jelly commented Oct 25, 2022

If for whatever reason cockpit-bridge-connector.pyz dies, cockpit will detect this and show a special page:

image

The reconnect option will however not work, maybe we should just remove it?

@martinpitt
Copy link
Member

This means that our multiplexer.py does not properly handle closing of the target machine websocket, like it does for the browser websocket? Let's fix that, and also move the session state to "closing" then, so that our own "the session has ended page appears instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants