Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changefeedccl: deflake TestChangefeedBackfillCheckpoint #142011

Merged

Conversation

andyyang890
Copy link
Collaborator

This patch deflakes TestChangefeedBackfillCheckpoint by adding a
retry loop for an expected test condition.

Fixes #141968

Release note: None

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@andyyang890 andyyang890 force-pushed the 20250225-deflake-backfill-checkpoint branch from e488836 to 29dbd73 Compare February 26, 2025 00:18
@andyyang890 andyyang890 marked this pull request as ready for review February 26, 2025 00:19
@andyyang890 andyyang890 requested a review from a team as a code owner February 26, 2025 00:19
@andyyang890 andyyang890 requested review from rharding6373 and aerfrei and removed request for a team February 26, 2025 00:19
Copy link
Contributor

@aerfrei aerfrei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! Sorry to have introduced this flake

@andyyang890 andyyang890 force-pushed the 20250225-deflake-backfill-checkpoint branch 2 times, most recently from 3934a09 to 544465a Compare February 26, 2025 16:41
This patch deflakes `TestChangefeedBackfillCheckpoint` by adding a
retry loop for an expected test condition.

Release note: None
@andyyang890 andyyang890 force-pushed the 20250225-deflake-backfill-checkpoint branch from 544465a to 56022fb Compare February 26, 2025 18:13
@andyyang890
Copy link
Collaborator Author

TFTR!

bors r=aerfrei

@craig craig bot merged commit 4348689 into cockroachdb:master Feb 26, 2025
23 of 24 checks passed
@andyyang890 andyyang890 deleted the 20250225-deflake-backfill-checkpoint branch February 26, 2025 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ccl/changefeedccl: TestChangefeedBackfillCheckpoint failed
3 participants