sql: initialize virtual table descriptors concurrently; skip some vtable validations #142012
+43
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
rafiss
force-pushed
the
concurrent-init-vtable
branch
from
c803c31 to
8b3928b
Compare
rafiss
changed the title
rafiss
force-pushed
the
concurrent-init-vtable
branch
from
8b3928b to
3a75994
Compare
Release note: None
This helps improve TestServer startup time. While working on this, I experimented with adding a concurrency limit, which didn't turn out to matter. However, I still kept the addition of SetLimit to the ctxgroup API, since it is generally useful. Release note: None
This patch skips an expensive validation step when running in a unit test. The virtual tables are all initialized on startup, and validating all of them at once leads to many heap allocations that cause TestServer startup to take longer. Release note: None
rafiss
force-pushed
the
concurrent-init-vtable
branch
from
3a75994 to
959ef1f
Compare
fqazi
approved these changes
Feb 26, 2025
There was a problem hiding this comment.
Nice!
Reviewed 1 of 1 files at r1, 2 of 2 files at r2, 2 of 2 files at r3, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @rafiss)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits.
Epic: None