roachtest: Update lib/pq block list #142038
Conversation
|
This change is |
| @@ -30,6 +30,11 @@ var libPQBlocklist = blocklist{ | |||
| "pq.TestRowsColumnTypes": "41688", | |||
| "pq.TestRuntimeParameters": "12137", | |||
| "pq.TestStringWithNul": "26366", | |||
| // The following tests fail because they weren't designed for the | |||
| // autocommit_before_ddl behaviour in CRDB. | |||
| "pq.TestCopyInWrongType": "unknown", | |||
There was a problem hiding this comment.
super nit: instead of "unknown", can we put in a short verbal description, or just this PR number so there's a breadcrumb
There was a problem hiding this comment.
Makes sense. I couldn't find a suitable precedence for this sort of thing.
The recent autocommit_before_ddl change (cockroachdb#141145) has affected three lib/pq tests that were not designed with autocommit behavior in mind. These tests were executing the following sequence: ``` BEGIN CREATE TEMP TABLE COPY ``` Since CREATE TEMP TABLE now triggers an auto-commit, the subsequent COPY command fails because it must run inside an active transaction. The error observed was: "pq: COPY is only allowed inside a transaction." Epic: none Release note: none Closes cockroachdb#141899
spilchen
force-pushed
the
gh-141899/250226/1057/lib/pq/pr-ready
branch
from
83b0ce6 to
448e551
Compare
There was a problem hiding this comment.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @rafiss)
| @@ -30,6 +30,11 @@ var libPQBlocklist = blocklist{ | |||
| "pq.TestRowsColumnTypes": "41688", | |||
| "pq.TestRuntimeParameters": "12137", | |||
| "pq.TestStringWithNul": "26366", | |||
| // The following tests fail because they weren't designed for the | |||
| // autocommit_before_ddl behaviour in CRDB. | |||
| "pq.TestCopyInWrongType": "unknown", | |||
There was a problem hiding this comment.
Makes sense. I couldn't find a suitable precedence for this sort of thing.
Yes, good point. I'll get this back ported. I'll leave the labels off this PR because I don't want blathers to create a new PR. Instead I'll cherry pick the commit into these two PRs: #141851 and #141987 |
|
TFTR! bors r+ |
The recent autocommit_before_ddl change (#141145) has affected three lib/pq tests that were not designed with autocommit behavior in mind.
These tests were executing the following sequence:
Since CREATE TEMP TABLE now triggers an auto-commit, the subsequent COPY command fails because it must run inside an active transaction. The error observed was: "pq: COPY is only allowed inside a transaction."
Epic: none
Release note: none
Closes #141899