Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachtest: Update psycopg block list #142047

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

spilchen
Copy link
Contributor

@spilchen spilchen commented Feb 26, 2025

This allows failures for some tests in the pscyopg tests that were due to the recent autocommit_before_ddl change in #141145. Rationale for each failing test are included as comments in the block list.

I will backport this in: #141987 #141851.

Epic: none
Release note: none
Closes #141884

@spilchen spilchen self-assigned this Feb 26, 2025
@cockroach-teamcity
Copy link
Member

This change is Reviewable

This allows failures for some tests in the pscyopg tests that were due
to the recent autocommit_before_ddl change in cockroachdb#141145. Rationale for
each failing test are included as comments in the block list.

Epic: none
Release note: none
Closes cockroachdb#141884
@spilchen spilchen force-pushed the gh-141884/250226/1443/psycopg-block-update/pr-ready branch from 9b68a7f to a9e8b8e Compare February 26, 2025 19:13
@spilchen spilchen marked this pull request as ready for review February 26, 2025 19:15
@spilchen spilchen requested a review from a team February 26, 2025 19:22
Copy link
Contributor

@Dedej-Bergin Dedej-Bergin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @spilchen)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

roachtest: psycopg failed
3 participants