Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write tests for GitHub.Sync.pull_request_event/1 #1372

Open
5 of 9 tasks
begedin opened this issue Jan 17, 2018 · 3 comments
Open
5 of 9 tasks

Write tests for GitHub.Sync.pull_request_event/1 #1372

begedin opened this issue Jan 17, 2018 · 3 comments

Comments

@begedin
Copy link
Contributor

begedin commented Jan 17, 2018

Problem

GitHub.Sync.pull_request_event/1 is currently completely untested. Since we want to unit test it's individual elements to, it should suffice to test each possible outcome of the transaction performed by the tests, as defined by GitHub.Sync.pull_request_event_outcome()

Subtasks

  • write test for {:ok, map} outcome
  • write test for {:error, :repo_not_found} outcome
  • write test for {:error, :fetching_issue, struct} outcome
  • write test for {:error, :validating_github_pull_request, Changeset.t()} outcome
  • write test for {:error, :validating_github_issue, Changeset.t()} outcome
  • write test for {:error, :validating_user, Changeset.t()} outcome
  • write test for {:error, :multiple_issue_users_match} outcome
  • write test for {:error, :validating_task, Changeset.t()} outcome
  • write test for {:error, :unexpected_transaction_outcome, any} outcome
@vishaldeepak
Copy link
Contributor

vishaldeepak commented Jan 29, 2018

@begedin Any major changes coming up to this or should i start working? Talking with reference similar to this #1374 (comment)

@begedin
Copy link
Contributor Author

begedin commented Jan 29, 2018

@vishaldeepak Same as #1374, I would recommend branching off of #1370 and then submitting a PR against that onne. Once #1370 is merged, we can then rebase onto develop.

@zacck-zz
Copy link
Member

zacck-zz commented Feb 27, 2018

Going to jump on this one since its still up for grabs ...

@zacck-zz zacck-zz self-assigned this Feb 27, 2018
@vishaldeepak vishaldeepak removed their assignment Feb 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants