Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify Conversation serializer to handle includes based on JSON API sideposting draft #1624

Open
begedin opened this issue Dec 18, 2017 · 1 comment
Labels

Comments

@begedin
Copy link
Contributor

begedin commented Dec 18, 2017

Problem

From https://github.com/json-api/json-api/pull/1197/files?short_path=571f6ce#diff-571f6cee9a492e0e177801c21a4b2b2a

When creating a conversation alongside a message, we need to generate a tempId for that conversation. The tempId needs to appear as temp-id both in the json['data']['relationship'] identifier as well as the json['included'] section and needs to be posted to the API.

References

Needs to be implemented together with #1303 code-corps/code-corps-api#1303.

The code this needs to modify is in #1597, so this should be considered blocked until that is merged.

@joshsmith
Copy link
Contributor

Referencing my own comment on the API side, we may want to hold off on this for awhile. The temp-id is likely to become tid, indicating the churn in JSON API is high enough we likely don't want to tie ourselves to a draft that's not yet accepted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants