Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor]: Change buttons.py to sidebar_toggle_button.py #15

Closed
1 task done
ihsanKisi opened this issue May 2, 2024 · 3 comments · Fixed by #18
Closed
1 task done

[Refactor]: Change buttons.py to sidebar_toggle_button.py #15

ihsanKisi opened this issue May 2, 2024 · 3 comments · Fixed by #18
Assignees
@ihsanKisi
Labels
🚀refactoring Related to code improvements

Comments

@ihsanKisi
Copy link

✏️ Problem Description

The current name is confusing.

💡 Feature Request

Change the name to SidebarToggleButton

🌍 Context

No response

🔍 Additional Information

No response

👍 Code of Conduct

  • I agree to follow this project's Code of Conduct
@ihsanKisi ihsanKisi added the 🚀refactoring Related to code improvements label May 2, 2024
@ihsanKisi ihsanKisi self-assigned this May 2, 2024
@ihsanKisi ihsanKisi changed the title [Refactor]: Change buttons.py to SidebarToggleButton [Refactor]: Change buttons.py to sidebar_toggle_button.py May 2, 2024
@aiakide
Copy link
Collaborator

aiakide commented May 16, 2024

Ok, I got the point.
I would suggest creating a module called buttons that contains multiple button implementations.
The fully qualified name of the sidebar button would be something like nicemldashboard.basecomponents.buttons.SidebarToggleButton.

@ihsanKisi
Copy link
Author

ihsanKisi commented May 16, 2024 •
edited
Loading

Hi. Thanks, that sounds good. I will update it accordingly.

@ihsanKisi ihsanKisi linked a pull request May 23, 2024 that will close this issue
refactor: move the button component to buttons module for clarity #18
Merged
7 tasks
@aiakide
Copy link
Collaborator

aiakide commented May 28, 2024

Solved by #18

@aiakide aiakide closed this as completed May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ihsanKisi ihsanKisi

Labels
🚀refactoring Related to code improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: move the button component to buttons module for clarity codecentric-oss/niceml-dashboard
2 participants
@aiakide @ihsanKisi