Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: niceml init does not use ruff rules #66

Open
1 task done
aiakide opened this issue Aug 11, 2023 · 0 comments
Open
1 task done

[Bug]: niceml init does not use ruff rules #66

aiakide opened this issue Aug 11, 2023 · 0 comments
Labels
🪲 bug Related to bugs or unexpected behavior 📋 needs review Requires code or design review ♻️ refactoring Related to refactoring or restructuring code

Comments

@aiakide
Copy link
Collaborator

aiakide commented Aug 11, 2023

📝 Description

When you run niceml init and select to use the pre-commit hooks, the pre-commit hooks are installed, but no rules are enabled in the configuration in pyproject.toml.

🎯 Expected Behavior

At least a small selected set of ruff rules is activated via niceml init.

🐞 Current Behavior

There are no ruff rules defined in pyproject.toml.

[tool.poetry.group.dev.dependencies]
pytest = "^7.3.1"
pre-commit = "^3.3.1"

[tool.ruff]
line-length = 100



[build-system]
requires = ["poetry-core>=1.0.0"]
build-backend = "poetry.core.masonry.api"

🔁 Steps to Reproduce

Run niceml init

⚙️ Technical Details

No response

💡 Suggestions or Possible Solutions

Add a set of ruff rules into the project template

Code of Conduct

  • I agree to follow this project's Code of Conduct
@aiakide aiakide added 🪲 bug Related to bugs or unexpected behavior 📋 needs review Requires code or design review ♻️ refactoring Related to refactoring or restructuring code labels Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪲 bug Related to bugs or unexpected behavior 📋 needs review Requires code or design review ♻️ refactoring Related to refactoring or restructuring code
Projects
None yet
Development

No branches or pull requests

1 participant