From ccf861226571ab4fc694013093689deed45e7d80 Mon Sep 17 00:00:00 2001 From: joseph-sentry <136376984+joseph-sentry@users.noreply.github.com> Date: Fri, 8 Mar 2024 16:57:56 -0500 Subject: [PATCH] chore: improve error message for finding reports (#396) also runs `make lint` --- codecov_cli/services/upload/upload_collector.py | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/codecov_cli/services/upload/upload_collector.py b/codecov_cli/services/upload/upload_collector.py index 282c0e99..d687ab98 100644 --- a/codecov_cli/services/upload/upload_collector.py +++ b/codecov_cli/services/upload/upload_collector.py @@ -153,9 +153,13 @@ def generate_upload_data(self, report_type="coverage") -> UploadCollectionResult files = self.file_finder.find_files() logger.info(f"Found {len(files)} {report_type} files to upload") if not files: + if report_type == "test_results": + error_message = "No JUnit XML reports found. Please review our documentation (https://docs.codecov.com/docs/test-result-ingestion-beta) to generate and upload the file." + else: + error_message = "No coverage reports found. Please make sure you're generating reports successfully." raise click.ClickException( click.style( - f"No {report_type} reports found. Please make sure you're generating reports successfully.", + error_message, fg="red", ) ) @@ -164,7 +168,9 @@ def generate_upload_data(self, report_type="coverage") -> UploadCollectionResult return UploadCollectionResult( network=network, files=files, - file_fixes=self._produce_file_fixes_for_network(network) - if report_type == "coverage" - else [], + file_fixes=( + self._produce_file_fixes_for_network(network) + if report_type == "coverage" + else [] + ), )