Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{Codecov upload issue debugging} - Ensuring the Codecov UI is able to react to data from the latest upload #2684

Open
rohan-at-sentry opened this issue Oct 16, 2024 · 0 comments
Assignees
Labels
Area: Report Processing Issues with report processing Area: Report Upload Issues with pre-ingest report uploading Dependency Dependency between teams in discovery The design, product, and specifications require refinement
Milestone

Comments

@rohan-at-sentry
Copy link

rohan-at-sentry commented Oct 16, 2024

Problem

The Codecov UI is essentially static after the first report upload - which is problematic in the following scenarios

  • when the user uploads multiple coverage reports per commit : coverage data on the UI is wrong as it only shows the results after first upload
  • when the user uploads a single coverage report per commit, and (for reasons) chooses to re-run CI on the same commit : coverage data on the UI is wrong as it only shows the results after first upload
  • whenthe user uploads multiple coverage reports per commit

We want to ensure the Codecov UI updates data shown on it with every report upload. This will help ensure consistency of report processing outcomes across PR comment and APP (commit and PR).

Why is it important?

Not seeing consistency on what you see on the PR reflect what you see confuses people.

Path forward

  • ensure the coverage report errors on the commits tab are shown/not shown based on if the latest coverage report upload was successful

  • Update top level coverage statistics for the commit and PR with result from latest result Image

  • Set notify_error to true for all new customers (the default appears to be false). This allows any issues with uploads to surface on the PR comment as well --> serves as a warning signal to users that coverage reporting on the UI may be impacted.

@rohan-at-sentry rohan-at-sentry added Area: Report Processing Issues with report processing Area: Report Upload Issues with pre-ingest report uploading labels Oct 16, 2024
@rohan-at-sentry rohan-at-sentry added this to the Q4 '24 milestone Oct 16, 2024
@rohan-at-sentry rohan-at-sentry self-assigned this Oct 16, 2024
@rohan-at-sentry rohan-at-sentry added Dependency Dependency between teams in discovery The design, product, and specifications require refinement labels Oct 16, 2024
@rohan-at-sentry rohan-at-sentry changed the title Codecov upload issue debugging for Q4 {Codecov upload issue debugging} - Ensuring the Codecov UI is able to react to data from the latest upload Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Report Processing Issues with report processing Area: Report Upload Issues with pre-ingest report uploading Dependency Dependency between teams in discovery The design, product, and specifications require refinement
Projects
Status: Consideration / Planning
Development

No branches or pull requests

3 participants