From 86900080cbc37418f5134cb0a8e7574a12722744 Mon Sep 17 00:00:00 2001 From: nicholas-codecov Date: Mon, 6 Jan 2025 06:29:52 -0500 Subject: [PATCH] Revert "feat: Fetch isCached Field with CommitPageDataQueryOpts (#3621)" This reverts commit 7cb7400269293841f26b8c83010f55c8e175881d. --- .../CommitBundleAnalysis.test.tsx | 4 ---- .../CommitCoverage/CommitCoverage.test.jsx | 4 ---- .../CommitDetailPage.test.tsx | 4 ---- .../queries/CommitPageDataQueryOpts.test.tsx | 10 +--------- .../queries/CommitPageDataQueryOpts.tsx | 20 +------------------ 5 files changed, 2 insertions(+), 40 deletions(-) diff --git a/src/pages/CommitDetailPage/CommitBundleAnalysis/CommitBundleAnalysis.test.tsx b/src/pages/CommitDetailPage/CommitBundleAnalysis/CommitBundleAnalysis.test.tsx index 68cf301ffe..782c7d3bc8 100644 --- a/src/pages/CommitDetailPage/CommitBundleAnalysis/CommitBundleAnalysis.test.tsx +++ b/src/pages/CommitDetailPage/CommitBundleAnalysis/CommitBundleAnalysis.test.tsx @@ -41,10 +41,6 @@ const mockCommitPageData = ({ __typename: 'Comparison', }, bundleAnalysis: { - bundleAnalysisReport: { - __typename: 'BundleAnalysisReport', - isCached: false, - }, bundleAnalysisCompareWithParent: { __typename: firstPullRequest ? 'FirstPullRequest' diff --git a/src/pages/CommitDetailPage/CommitCoverage/CommitCoverage.test.jsx b/src/pages/CommitDetailPage/CommitCoverage/CommitCoverage.test.jsx index 1b49948344..b4a08236e9 100644 --- a/src/pages/CommitDetailPage/CommitCoverage/CommitCoverage.test.jsx +++ b/src/pages/CommitDetailPage/CommitCoverage/CommitCoverage.test.jsx @@ -317,10 +317,6 @@ const mockCommitPageData = ( : 'Comparison', }, bundleAnalysis: { - bundleAnalysisReport: { - __typename: 'BundleAnalysisReport', - isCached: false, - }, bundleAnalysisCompareWithParent: { __typename: 'BundleAnalysisComparison', }, diff --git a/src/pages/CommitDetailPage/CommitDetailPage.test.tsx b/src/pages/CommitDetailPage/CommitDetailPage.test.tsx index 842d5650f3..84365a90db 100644 --- a/src/pages/CommitDetailPage/CommitDetailPage.test.tsx +++ b/src/pages/CommitDetailPage/CommitDetailPage.test.tsx @@ -53,10 +53,6 @@ const mockCommitPageData = ({ __typename: 'Comparison', }, bundleAnalysis: { - bundleAnalysisReport: { - __typename: 'BundleAnalysisReport', - isCached: false, - }, bundleAnalysisCompareWithParent: { __typename: 'BundleAnalysisComparison', }, diff --git a/src/pages/CommitDetailPage/queries/CommitPageDataQueryOpts.test.tsx b/src/pages/CommitDetailPage/queries/CommitPageDataQueryOpts.test.tsx index 34e934284f..456c92fbab 100644 --- a/src/pages/CommitDetailPage/queries/CommitPageDataQueryOpts.test.tsx +++ b/src/pages/CommitDetailPage/queries/CommitPageDataQueryOpts.test.tsx @@ -23,10 +23,6 @@ const mockCommitData = { __typename: 'Comparison', }, bundleAnalysis: { - bundleAnalysisReport: { - __typename: 'BundleAnalysisReport', - isCached: false, - }, bundleAnalysisCompareWithParent: { __typename: 'BundleAnalysisComparison', }, @@ -93,7 +89,7 @@ interface SetupArgs { isNullOwner?: boolean } -describe('CommitPageData', () => { +describe('useCommitPageData', () => { function setup({ isNotFoundError = false, isOwnerNotActivatedError = false, @@ -150,10 +146,6 @@ describe('CommitPageData', () => { __typename: 'Comparison', }, bundleAnalysis: { - bundleAnalysisReport: { - __typename: 'BundleAnalysisReport', - isCached: false, - }, bundleAnalysisCompareWithParent: { __typename: 'BundleAnalysisComparison', }, diff --git a/src/pages/CommitDetailPage/queries/CommitPageDataQueryOpts.tsx b/src/pages/CommitDetailPage/queries/CommitPageDataQueryOpts.tsx index 7f23c4b671..a1634ec141 100644 --- a/src/pages/CommitDetailPage/queries/CommitPageDataQueryOpts.tsx +++ b/src/pages/CommitDetailPage/queries/CommitPageDataQueryOpts.tsx @@ -17,16 +17,6 @@ import Api from 'shared/api' import { rejectNetworkError } from 'shared/api/helpers' import A from 'ui/A' -const BundleAnalysisReportSchema = z.object({ - __typename: z.literal('BundleAnalysisReport'), - isCached: z.boolean(), -}) - -const BundleAnalysisReportUnion = z.union([ - BundleAnalysisReportSchema, - MissingHeadReportSchema.shape.__typename, -]) - const BundleAnalysisComparisonResult = z.union([ z.literal('BundleAnalysisComparison'), FirstPullRequestSchema.shape.__typename, @@ -64,7 +54,6 @@ const RepositorySchema = z.object({ .nullable(), bundleAnalysis: z .object({ - bundleAnalysisReport: BundleAnalysisReportUnion.nullable(), bundleAnalysisCompareWithParent: z .object({ __typename: BundleAnalysisComparisonResult, @@ -109,12 +98,6 @@ query CommitPageData($owner: String!, $repo: String!, $commitId: String!) { __typename } bundleAnalysis { - bundleAnalysisReport { - __typename - ... on BundleAnalysisReport { - isCached - } - } bundleAnalysisCompareWithParent { __typename } @@ -129,8 +112,7 @@ query CommitPageData($owner: String!, $repo: String!, $commitId: String!) { } } } -} -` +}` interface CommitPageDataQueryArgs { provider: string