Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mismatch between user interface and subscription boundaries #291

Open
jszwedko opened this issue Aug 13, 2018 · 2 comments
Open

Mismatch between user interface and subscription boundaries #291

jszwedko opened this issue Aug 13, 2018 · 2 comments

Comments

@jszwedko
Copy link
Contributor

jszwedko commented Aug 13, 2018

When creating a subscription, the user is shown a circle with a radius equal to the distance they specify, but when creating the subscription the bounding box of the displayed circle is used. While unlikely, I believe this could lead to confusion as people receive notifications for an area outside of what they may have thought they were signing up for.

I imagine this decision was made due to the lack of support of a circle feature in GeoJSON.

I personally see two options for increasing clarity:

  • Approximating the circle with a polygon with a high number of sides. Having limited experience with PostgresSQL's GIS support, I'm not sure what implications this has for calculating intersections, but my gut feels that it'd probably increase the computations required.
  • Display a rectangle rather than a circle on the map when the user is registering

I was curious what people think or if there a reason the current design was chosen. I poked around, but couldn't determine if there was a rationale for the current mismatch. If nothing else, I figured this issue could serve as a record 😄

@bigfleet
Copy link
Contributor

bigfleet commented Oct 2, 2018

@invisiblefunnel does this sound familiar to you?

@invisiblefunnel
Copy link
Member

I imagine this decision was made due to the lack of support of a circle feature in GeoJSON.

Ya, I think that was the reason.

An alternative is to store the center point and radius, then use ST_DWithin to find actionable events. Backfilling existing subscriptions could also be done with a little bit of PostGIS magic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants