Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flipping the address validation logic, so it's consistent with our patterns #665

Merged
merged 2 commits into from
Feb 25, 2025
Merged

flipping the address validation logic, so it's consistent with our patterns #665

merged 2 commits into from
Feb 25, 2025

Conversation

cram-cfa
Copy link
Collaborator

Issue tracking number 🔗

Description of change ✍️

Priority 🥇

Effect on other applications using FFB 🌊

Testing

✅ Checklist before requesting a review

  • Does the new code follow our preferred coding
    style    ?
  • Does the code include javadocs, where necessary?
  • Have tests for this feature been added / updated?
  • Has the readme been updated?

@cram-cfa cram-cfa requested a review from spokenbird February 24, 2025 22:18
@cram-cfa cram-cfa mentioned this pull request Feb 24, 2025
Merged
2 tasks
@cram-cfa cram-cfa merged commit af6ebef into main Feb 25, 2025
5 checks passed
@cram-cfa cram-cfa deleted the flip-address-validation-logic branch February 25, 2025 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spokenbird spokenbird spokenbird approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cram-cfa @spokenbird