New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify the existing old EnergyUseHistoryChart to match the new design (check columns, headers, etc). #248

Open

2 of 5 tasks

thadk opened this issue Sep 11, 2024 · 1 comment

Labels

Member

thadk commented Sep 11, 2024 •

edited by dwindleduck

Loading

Per design, bold the items and add the Number of periods included denominator/total.
Help text icons (title, allowed usage, override default)
thousand commas on Whole-home UA BTU (use browser locale functionality or d3format)
number of period denominator, not just included periods.'
minor table styling to match design (troubleshoot: shadcn header color, outline, rounded corners, etc)

see #221 for further details

thadk mentioned this issue

Draw EnergyUseHistoryChart component accepting Rules Engine data as parameter/prop #221

Closed

7 tasks

Collaborator

dwindleduck commented Nov 1, 2024

Opened this PR with progress on this issue.

Complete:

added the total periods to the denominator of Number of Periods Included
added static help icon images in three locations (should create a reusable component?)
updated some styling to more closely match the design

Still needs attention:

thousand commas on Whole-home UA BTU (use browser locale functionality or d3format)
tailwind's border radius utilities (rounded-md) not yet working on the chart
help icons are static

thadk linked a pull request

that will close this issue

248 styling #266

Merged

thadk removed a link to a pull request

248 styling #266

Merged

ethanstrominger added the heat-app-js label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment