From 1a79e44c9f13925b03315d9de3678fb748ade0a1 Mon Sep 17 00:00:00 2001 From: hiroTochigi Date: Tue, 2 Feb 2021 22:42:18 -0600 Subject: [PATCH 1/2] handle null event --- api/tests.py | 10 +++++++++- api/views.py | 4 +++- 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/api/tests.py b/api/tests.py index c845e683..44289a39 100644 --- a/api/tests.py +++ b/api/tests.py @@ -3,7 +3,11 @@ from django.test import RequestFactory, TestCase -from .views import reminders, eligible_jurisdiction +from .views import ( + reminders, + eligible_jurisdiction, + find_arraignment_or_return_False, + ) from alerts.models import Alert @@ -94,3 +98,7 @@ def testEligibleJurisdictions(self): 'seminole', 'sequoyah', 'stephens', 'texas', 'tillman', 'tulsa', 'wagoner', 'washington', 'washita', 'woods', 'woodward']}) + + def testfindArraignmentOrReturnFalseEventNone(self): + events = [None, None, None] + diff --git a/api/views.py b/api/views.py index 9052c0e9..375b956c 100644 --- a/api/views.py +++ b/api/views.py @@ -107,7 +107,9 @@ def eligible_jurisdiction(request): def find_arraignment_or_return_False(events): for event in events: - if "arraignment" in event.Docket.lower(): + if not event: + return False + if "arraignment" in event.Event.lower(): return event return False From 2353f7a0016414ad259f804fa2554d2c9200af2c Mon Sep 17 00:00:00 2001 From: hiroTochigi Date: Tue, 2 Feb 2021 23:23:08 -0600 Subject: [PATCH 2/2] handle error --- api/tests.py | 10 ++++++---- api/views.py | 4 ++-- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/api/tests.py b/api/tests.py index 44289a39..fbb0af12 100644 --- a/api/tests.py +++ b/api/tests.py @@ -14,6 +14,12 @@ class testReminders(TestCase): def setUp(self): self.factory = RequestFactory() + class Event: + case_index + Docket + Event + Party + Reporter def _post(self, url, params): return self.factory.post(url, params) @@ -98,7 +104,3 @@ def testEligibleJurisdictions(self): 'seminole', 'sequoyah', 'stephens', 'texas', 'tillman', 'tulsa', 'wagoner', 'washington', 'washita', 'woods', 'woodward']}) - - def testfindArraignmentOrReturnFalseEventNone(self): - events = [None, None, None] - diff --git a/api/views.py b/api/views.py index 375b956c..692b72dc 100644 --- a/api/views.py +++ b/api/views.py @@ -107,8 +107,8 @@ def eligible_jurisdiction(request): def find_arraignment_or_return_False(events): for event in events: - if not event: - return False + if not "Event" in dir(event): + continue if "arraignment" in event.Event.lower(): return event return False