Skip to content
This repository has been archived by the owner on Oct 9, 2019. It is now read-only.

Add monaco editor #227

Open
jatinkatyal13 opened this issue May 22, 2019 · 9 comments
Open

Add monaco editor #227

jatinkatyal13 opened this issue May 22, 2019 · 9 comments

Comments

@jatinkatyal13
Copy link
Contributor

Replace Ace Editor that we currently use with Monaco Editor for Ember.

@shubhamofbce
Copy link

I would like to work on this issue!!

@sameshl
Copy link

sameshl commented May 25, 2019

@jatinkatyal13 I would like to like to work on this issue but would like some help from you. Can you please share some links with relevant info so I can get started with this issue.

@sudo-nan0-RaySK
Copy link

I am willing to take this!

@sudo-nan0-RaySK
Copy link

The version of ember-monaco you have suggested is no doubt maintained. However it has issues regarding CommonJS transforms. It is due to a node module named 'penpal'. The older ember-monaco-editor has no such dependencies however. Should i go forward with it?

@abhishek97
Copy link
Contributor

What issues exactly? We already are using that plugin online CodingBlocks frontend. Can you elaborate the issue or a link perhaps?

@sudo-nan0-RaySK
Copy link

Okay so when i install the above add-on, what i get is an error stating unknown transformation name 'cjs'. I have used the above add on in my project, it works fine in there but with hacker-blocks frontend I get this error. Only difference is the ember version.

@abhishek97
Copy link
Contributor

Have you tried installing https://github.com/rwjblue/ember-cli-cjs-transform ?

@sudo-nan0-RaySK
Copy link

Yes, That's the first thing I did. Also the Monaco Editor for Ember add on uses it internally for importing Penpal.Like have a look at its index.js

@RAJAGOPALAN-GANGADHARAN

@abhishek97 is this one open for working? I have experiences using ace editor so might be suitable for me
😄
Thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants