You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently each developer has to setup flake8 on their own and look into the test_flake8.py for what rules should be ignored and what files to run it on.
Unrelated to this but, @dirk-thomas what's your opinion about switching to black or leave it up to each extension to decide the formatter/linter of choice?
I've used black consistently, it has excellent editors support and I haven't seen any notable bug when using it. It can be used both as a linter or as a formatter, and we can also lose the test_flake8.py file as well.
The text was updated successfully, but these errors were encountered:
bergercookie
changed the title
Add script / instructions for running the flake8 formatter locally
Add script / instructions for running the code formatter locally
Nov 9, 2020
Since each package already decides it's own tests this package can use whatever it prefers. I don't see a strong reason to change what is used for other packages though.
@lelongg , what do you think of using black in this repo?
There might be a first PR that changes multiple lines to adhere to black, (e.g., changing single quotes to double, which is also reported as a warning by flake) but after that, maintaining it and checking for errors both for developers and in CI will be simplified significantly IMO.
I can make a first pass + PR to show you how that would look..
Currently each developer has to setup flake8 on their own and look into the
test_flake8.py
for what rules should be ignored and what files to run it on.Unrelated to this but, @dirk-thomas what's your opinion about switching to black or leave it up to each extension to decide the formatter/linter of choice?
I've used
black
consistently, it has excellent editors support and I haven't seen any notable bug when using it. It can be used both as a linter or as a formatter, and we can also lose thetest_flake8.py
file as well.The text was updated successfully, but these errors were encountered: