You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I agree that in an ideal world, that would be a nice naming convention, but in reality some projects do not conform to that because CMake doesn't make them. Examples:
Can we make the regex more lax, without breaking other things in colcon? The fallback behavior to the directory name is good, but it shouldn't happen when there is a valid CMake project name specified.
The text was updated successfully, but these errors were encountered:
Is there a reason why colcon will only accept project names that have alphanumerics, dashes and underscores?
https://github.com/colcon/colcon-cmake/blob/master/colcon_cmake/package_identification/cmake.py#L165
I agree that in an ideal world, that would be a nice naming convention, but in reality some projects do not conform to that because CMake doesn't make them. Examples:
Can we make the regex more lax, without breaking other things in colcon? The fallback behavior to the directory name is good, but it shouldn't happen when there is a valid CMake project name specified.
The text was updated successfully, but these errors were encountered: