Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent behaviour when watched directory is not directly in process.cwd? #3

Open
b-ma opened this issue Jul 31, 2023 · 1 comment
Open

Inconsistent behaviour when watched directory is not directly in process.cwd? #3

b-ma opened this issue Jul 31, 2023 · 1 comment

Comments

@b-ma
Copy link
Collaborator

b-ma commented Jul 31, 2023

No description provided.

@b-ma b-ma changed the title Inconsistent behaviour when watched directory is not directly in process.cwd Inconsistent behaviour when watched directory is not directly in process.cwd? Aug 14, 2023
@b-ma
Copy link
Collaborator Author

b-ma commented Aug 14, 2023 •
edited
Loading

Most probably due to the inconsistency between sc-filetree API and plugin API, and internally between getTree format and edition methods API

We have kind of 2 conflicting point of views here:

  1. writeFile, rename, etc. should stick to the file path format used in getTree and not relatively to dirname
  2. The actual implementation of writeFile, rename, etc. is logical: we watch a directory and then work relatively inside this directory. In this case, this is the getTree() format which is not satisfying

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@b-ma