Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Soft depend on formlib #22

Closed
ale-rt opened this issue Apr 8, 2019 · 0 comments
Closed

Soft depend on formlib #22

ale-rt opened this issue Apr 8, 2019 · 0 comments

Comments

@ale-rt
Copy link
Member

ale-rt commented Apr 8, 2019

At the moment this packages depends on formlib:

collective.auditlog/collective/auditlog/action.py

Line 30 in 1c290ad

from zope.formlib import form

collective.auditlog/collective/auditlog/action.py

Lines 303 to 304 in 1c290ad

form_fields = form.FormFields(IAuditAction) # needed for Plone4 (formlib)
schema = IAuditAction # needed for Plone5 (z3c.form)

but the dependency is not declared in the setup.py

I think it is safe to make this a soft dependency and to not declare the form_fields attribute if formlib is not available.
ale-rt added a commit that referenced this issue Apr 8, 2019
@ale-rt
Fix soft dependency on formlib
5db3315 
Fixes #22
@ale-rt ale-rt mentioned this issue Apr 8, 2019
Merged
@pilz pilz closed this as completed in #23 Apr 9, 2019
thet added a commit that referenced this issue Dec 3, 2019
@thet
Backport changes from master branch into enfold/master:
2b1499d 
- Fix soft dependency on formlib (#22)
- Speed up rule retrieval
- Added some memoized properties and methods to the `AuditActionExecutor` class
  for easier customization
thet added a commit that referenced this issue Dec 3, 2019
@thet
Backport changes from master branch into enfold/master:
a54e385 
- Fix soft dependency on formlib (#22)
- Speed up rule retrieval
- Added some memoized properties and methods to the `AuditActionExecutor` class
  for easier customization
thet added a commit that referenced this issue Dec 3, 2019
@thet
Backport changes from master branch into enfold/master:
b3eea83 
- Fix soft dependency on formlib (#22)
- Speed up rule retrieval
- Added some memoized properties and methods to the `AuditActionExecutor` class
  for easier customization
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ale-rt