You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The way it's implemented right now for example gives the following error for https links in some providers:
2020-01-13 16:44:19 INFO sc.embedder There are no endpoints available for https://vimeo.com/384531827
Don't know if it's possible, but I would suggest taking https://github.com/itteco/iframely/blob/master/lib/plugins/system/oembed/providers.json inside the package and creating a dictionary that has these validations at runtime: upgrading the providers would mean just downlading a new json and adding it to the package. Using this approach we fix the regex problem as well since they are improved.
The text was updated successfully, but these errors were encountered:
idgserpro
changed the title
Get the list of providers on an alternative way
Get the list of providers on an alternative way and improved regexes for getting the url
Jan 13, 2020
See https://github.com/simplesconsultoria/sc.embedder/blob/262d279b25878d11706eb25c9b94a699789ed4e5/src/sc/embedder/utility.py#L7
The way it's implemented right now for example gives the following error for https links in some providers:
Don't know if it's possible, but I would suggest taking https://github.com/itteco/iframely/blob/master/lib/plugins/system/oembed/providers.json inside the package and creating a dictionary that has these validations at runtime: upgrading the providers would mean just downlading a new json and adding it to the package. Using this approach we fix the regex problem as well since they are improved.
The text was updated successfully, but these errors were encountered: