Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web Folder v0.3.11+ Affecting Custom Scripts .Preview Thumbnails Hover #6533

Closed
DeepSeaCatz opened this issue Jan 20, 2025 · 1 comment
Closed
Labels
Custom Nodes Bug Bugs caused by downstream custom nodes Frontend Issue relates to the frontend UI (litegraph).

Comments

@DeepSeaCatz
Copy link

Expected Behavior

There is an issue going on over Custom-Scripts custom node about the new web folder now displaying thumbnails .preview versions of models:
pythongosssss/ComfyUI-Custom-Scripts#413 (comment)

I tested a few versions back and the last web folder version of the portable is version 0.3.10. I am not quite sure what changed and if it's more of a custom node issue to update or if it's something that was overlooked. When hovering the model selection, a thumbnail of a .preview image of that model displays.
Image

Actual Behavior

On version 0.3.11 and latest 0.3.12, the thumbnails don't show up.

Steps to Reproduce

Right now I need to manually replace the web folder from 0.3.10 to keep that feature.

Debug Logs

With version 0.3.10 web:

Running on 127.0.0.1:8188
App.vue:42 ComfyUI Front-end version: 1.5.19
app.ts:1688 Error loading extension /extensions/ComfyUI-OpenPose-Editor-Plus/openpose.js SyntaxError: missing ) after argument list
(anonymous) @ app.ts:1688Understand this errorAI
app.ts:1688 Error loading extension /extensions/ComfyUI-OpenPose-Editor-Plus/fabricnew.min.js TypeError: Cannot read properties of undefined (reading 'fabric')
    at fabricnew.min.js:1:38397
    at fabricnew.min.js:1:50488
(anonymous) @ app.ts:1688Understand this errorAI
app.ts:1688 Error loading extension /extensions/ComfyUI_LayerStyle/dz_node_palette.js Error: Extension named 'ColorOverlay' already registered.
    at Proxy.registerExtension (extensionStore.ts:41:13)
    at Proxy.wrappedAction (pinia.mjs:1405:26)
    at ComfyApp.registerExtension (app.ts:2814:27)
    at dz_node_palette.js:4:5
(anonymous) @ app.ts:1688Understand this errorAI
extensionStore.ts:45 Extension pysssss.Locking is disabled.
extensionStore.ts:45 Extension pysssss.SnapToGrid is disabled.
mtb_input_output_sidebar.js:180  1.5.19
api.ts:380 Unhandled message: {"type": "crystools.monitor", "data": {"cpu_utilization": 18.0, "ram_total": 68407463936, "ram_used": 20811800576, "ram_used_percent": 30.4, "hdd_total": 2000396742656, "hdd_used": 1829037338624, "hdd_used_percent": 91.4, "device_type": "cuda", "gpus": [{"gpu_utilization": 13, "gpu_temperature": 36, "vram_total": 25769803776, "vram_used": 2238476288, "vram_used_percent": 8.686431248982746}]}} Error: Unknown message type crystools.monitor
    at WebSocket.<anonymous> (api.ts:375:23)
(anonymous) @ api.ts:380Understand this warningAI
playSound.js:7 PlayMusic
beforeRegisterNodeDef @ playSound.js:7Understand this warningAI
jsonToText.js:9 JsonToText
beforeRegisterNodeDef @ jsonToText.js:9Understand this warningAI
viewText.js:9 ViewText
beforeRegisterNodeDef @ viewText.js:9Understand this warningAI
components-manager.js:770 Empty components: policy ignored
util.js:881 JDCN Load Image Extension Loaded
17ttNinterface.js:269 Uncaught TypeError: node.onResize is not a function
    at ttNinterface.js:269:22Understand this errorAI
:8188/api/pysssss/autocomplete:1         
        
       Failed to load resource: the server responded with a status of 404 (Not Found)Understand this errorAI
:8188/extensions/ComfyUI-Custom-Scripts/js/assets/favicon-active.user.ico:1       
        
       Failed to load resource: the server responded with a status of 404 (Not Found)Understand this errorAI
:8188/extensions/ComfyUI-Custom-Scripts/js/assets/favicon.user.ico:1         
        
       Failed to load resource: the server responded with a status of 404 (Not Found)Understand this errorAI
127.0.0.1/:1 Uncaught (in promise) Error: A listener indicated an asynchronous response by returning true, but the message channel closed before a response was received






With 0.3.12:

962index-DjNHn37O.js:164223 Parameter defaultValue is deprecated. The default value in settings definition will be used instead.
getSettingValue @ index-DjNHn37O.js:164223Understand this warningAI
components-manager.js:770 Empty components: policy ignored
util.js:881 JDCN Load Image Extension Loaded
5index-DjNHn37O.js:164223 Parameter defaultValue is deprecated. The default value in settings definition will be used instead.
getSettingValue @ index-DjNHn37O.js:164223Understand this warningAI
17ttNinterface.js:269 Uncaught TypeError: node.onResize is not a function
    at ttNinterface.js:269:22Understand this errorAI
:8188/api/pysssss/autocomplete:1 
        
        
       Failed to load resource: the server responded with a status of 404 (Not Found)Understand this errorAI
:8188/extensions/ComfyUI-Custom-Scripts/js/assets/favicon-active.user.ico:1 
        
        
       Failed to load resource: the server responded with a status of 404 (Not Found)Understand this errorAI
:8188/extensions/ComfyUI-Custom-Scripts/js/assets/favicon.user.ico:1 
        
        
       Failed to load resource: the server responded with a status of 404 (Not Found)Understand this errorAI
12index-DjNHn37O.js:164223 Parameter defaultValue is deprecated. The default value in settings definition will be used instead.

Other

No response

@DeepSeaCatz DeepSeaCatz added the Potential Bug User is reporting a bug. This should be tested. label Jan 20, 2025
@DeepSeaCatz DeepSeaCatz changed the title Web folder Web Folder v0.3.11+ Affecting Custom Scripts .Preview Thumbnails Hover Jan 20, 2025
@huchenlei huchenlei added Frontend Issue relates to the frontend UI (litegraph). Custom Nodes Bug Bugs caused by downstream custom nodes and removed Potential Bug User is reporting a bug. This should be tested. labels Jan 20, 2025
@huchenlei
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Custom Nodes Bug Bugs caused by downstream custom nodes Frontend Issue relates to the frontend UI (litegraph).
Projects
None yet
Development

No branches or pull requests

2 participants