From 78938f3b8a9b45605b52fe2a47a88fde6df12e6f Mon Sep 17 00:00:00 2001 From: Jason Wen Date: Fri, 1 Dec 2023 11:17:49 -0500 Subject: [PATCH 1/2] Hyundai CAN: Fix `Elect_Gear_Shifter` Sport Gear value --- hyundai_kia_generic.dbc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hyundai_kia_generic.dbc b/hyundai_kia_generic.dbc index 3031c4bc22..0dfe8d9cc1 100644 --- a/hyundai_kia_generic.dbc +++ b/hyundai_kia_generic.dbc @@ -1651,7 +1651,7 @@ CM_ SG_ 1348 SpeedLim_Nav_Clu "Speed limit displayed on Nav, Cluster and HUD"; VAL_ 274 CUR_GR 1 "D" 2 "D" 3 "D" 4 "D" 5 "D" 6 "D" 7 "D" 8 "D" 14 "R" 0 "P"; VAL_ 871 CF_Lvr_IsgState 0 "enabled" 1 "activated" 2 "unknown" 3 "disabled"; VAL_ 871 CF_Lvr_Gear 12 "T" 5 "D" 8 "S" 6 "N" 7 "R" 0 "P"; -VAL_ 882 Elect_Gear_Shifter 5 "D" 8 "S" 6 "N" 7 "R" 0 "P"; +VAL_ 882 Elect_Gear_Shifter 4 "S" 5 "D" 6 "N" 7 "R" 0 "P"; VAL_ 905 ACCMode 0 "off" 1 "enabled" 2 "driver_override" 3 "off_maybe_fault" 4 "cancelled"; VAL_ 909 CF_VSM_Warn 2 "FCW" 3 "AEB"; VAL_ 916 ACCEnable 0 "SCC ready" 1 "SCC temp fault" 2 "SCC permanent fault" 3 "SCC permanent fault, communication issue"; From 25f8327b9408368d36b440436cdc71ad8f17231d Mon Sep 17 00:00:00 2001 From: Jason Wen Date: Fri, 22 Dec 2023 00:20:16 -0500 Subject: [PATCH 2/2] add back original value --- hyundai_kia_generic.dbc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hyundai_kia_generic.dbc b/hyundai_kia_generic.dbc index 8f888d5593..216ca6bfaf 100644 --- a/hyundai_kia_generic.dbc +++ b/hyundai_kia_generic.dbc @@ -112,7 +112,7 @@ BO_ 1265 CLU11: 4 CLU BO_ 1260 Sign_Detection: 8 XXX SG_ SpeedLim_Nav_Cam : 40|8@1+ (1,0) [0|255] "km/h / mph" XXX SG_ SpeedLim_Nav_Cam2 : 48|8@1+ (1,0) [0|255] "km/h / mph" XXX - + BO_ 1492 TMU_GW_PE_01: 8 CLU SG_ TMU_IVRActivity : 0|2@1+ (1.0,0.0) [0.0|3.0] "" DATC SG_ TMU_PhoneActivity : 2|2@1+ (1.0,0.0) [0.0|3.0] "" DATC @@ -1655,7 +1655,7 @@ CM_ SG_ 1348 SpeedLim_Nav_Clu "Speed limit displayed on Nav, Cluster and HUD"; VAL_ 274 CUR_GR 1 "D" 2 "D" 3 "D" 4 "D" 5 "D" 6 "D" 7 "D" 8 "D" 14 "R" 0 "P"; VAL_ 871 CF_Lvr_IsgState 0 "enabled" 1 "activated" 2 "unknown" 3 "disabled"; VAL_ 871 CF_Lvr_Gear 12 "T" 5 "D" 8 "S" 6 "N" 7 "R" 0 "P"; -VAL_ 882 Elect_Gear_Shifter 4 "S" 5 "D" 6 "N" 7 "R" 0 "P"; +VAL_ 882 Elect_Gear_Shifter 4 "S" 5 "D" 8 "S" 6 "N" 7 "R" 0 "P"; VAL_ 905 ACCMode 0 "off" 1 "enabled" 2 "driver_override" 3 "off_maybe_fault" 4 "cancelled"; VAL_ 909 CF_VSM_Warn 2 "FCW" 3 "AEB"; VAL_ 916 ACCEnable 0 "SCC ready" 1 "SCC temp fault" 2 "SCC permanent fault" 3 "SCC permanent fault, communication issue";