Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate quirks when rendering prices in Farsi #74

Open
bojanz opened this issue Feb 21, 2019 · 0 comments
Open

Investigate quirks when rendering prices in Farsi #74

bojanz opened this issue Feb 21, 2019 · 0 comments

Comments

@bojanz
Copy link
Contributor

bojanz commented Feb 21, 2019

Our number format for Farsi ("fa") puts the currency symbol before the amount.

However, PHP's native NumberFormatter varies the symbol location based on the currency:

$formatter = new \NumberFormatter('fa', \NumberFormatter::CURRENCY);
echo $formatter->formatCurrency('645000', 'USD'); // Symbol before the amount
echo $formatter->formatCurrency('645000', 'IRR'); // Symbol after the amount

This could be related to #65, where our logic is too simplistic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant