Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing CHE and CHW currencies #91

Open
philipheimboeck opened this issue Sep 3, 2024 · 2 comments
Open

Missing CHE and CHW currencies #91

philipheimboeck opened this issue Sep 3, 2024 · 2 comments

Comments

@philipheimboeck
Copy link

philipheimboeck commented Sep 3, 2024

The following currencies of the WIR Bank are currently not supported, but are part of ISO 4217

  • CHE, 947, WIR Euro
  • CHW, 948, WIR Franc

Guess besides the translations in the resource, the following should be added to the repository.

// src/Currency/CurrencyRepository.php
protected function getBaseDefinitions(): array
{
        return [
            // ....
            'CHE' => ['947', 2],
            'CHW' => ['948', 2],
       ];
}
@bojanz
Copy link
Contributor

bojanz commented Sep 3, 2024

We filter out every currency defined by ISO to be a "fund":
https://github.com/commerceguys/intl/blob/master/scripts/generate_currency_data.php#L90

I am not sure we want to change that in this library.

Could you tell us your use case?

@philipheimboeck
Copy link
Author

Our customers use this currency in Swiss for B2B. Basically they send invoices and payments in this currency to other companies. Because we want to offer them to be able to create and send these invoices and import payment statements into our system, we need to also support these currencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants