-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stack sdist
fails, given a Unicode package name
#6372
Comments
mpilgrem
added a commit
that referenced
this issue
Dec 10, 2023
mpilgrem
added a commit
that referenced
this issue
Dec 11, 2023
mpilgrem
added a commit
that referenced
this issue
Dec 11, 2023
Fix #6372 Allow stack sdist to check packages with non-ASCII names
mpilgrem
added a commit
that referenced
this issue
Apr 4, 2024
tar-0.6.2.0 supports Unicode in file names (encoded as UTF-8). Consequently, Stack no longer needs to UTF-8 encode file names. Also adds test of `stack sdist .` with Unicode in file names.
mpilgrem
added a commit
that referenced
this issue
Apr 5, 2024
tar-0.6.2.0 supports Unicode in file names (encoded as UTF-8). Consequently, Stack no longer needs to UTF-8 encode file names. Also adds test of `stack sdist .` with Unicode in file names.
mpilgrem
added a commit
that referenced
this issue
Apr 5, 2024
tar-0.6.2.0 supports Unicode in file names (encoded as UTF-8). Consequently, Stack no longer needs to UTF-8 encode file names. Also adds test of `stack sdist .` with Unicode in file names.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
For example, with
stack new test١٢٣
andstack sdist .
:The problem has its origins in the
tar
package.Codec.Archive.Tar.Types.fromTarPath
usesData.ByteString.Char8.unpack
and so the filepaths encoded with UTF8 are corrupted. Tar is unpacking toC:\Users\mike\AppData\Local\Temp\stack-63a2cee6f8c419cf\test١٢٣-0.1.0.0
.That is,
Stack.SDist.withTempTarGzContents
fails to behave as expected at theTar.unpack
step:Related matters: haskell/cabal#3758 (Lack of support for non-ASCII characters in cabal sdist) and haskell/tar#6 (Paths with unicode characters in them?).
The text was updated successfully, but these errors were encountered: