Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Caption and depiction sometimes not set #6162

Open
nicolas-raoul opened this issue Jan 27, 2025 · 2 comments
Open

Caption and depiction sometimes not set #6162

nicolas-raoul opened this issue Jan 27, 2025 · 2 comments

Comments

@nicolas-raoul
Copy link
Member

Example:
https://commons.m.wikimedia.org/wiki/File%3AFrench_ambassador_in_Tokyo%2C_Philippe_Setton.jpg

When that happens, the uploaded image does not appear in the contributions activity, I have to swipe down to refresh and make it appear.

@RitikaPahwa4444
Copy link
Collaborator

When that happens, the uploaded image does not appear in the contributions activity

Had faced this issue when I was testing for #5280, but I don't remember if it was fixed later. The recently added swipe down to refresh functionality fetches the latest list from the server, so I expect it to appear. The two might be related.

@nicolas-raoul
Copy link
Member Author

You are right, it is most probably the now way this old problem shows up.

Summary for newcomers: For API reasons, upload of an image has two steps:

  1. Upload the file/description/categories
  2. Set the captions/depictions

Network issues are inevitable so we should probably:

  • Keep half-uploaded images in the "Pending" panel. Visually it is OK if it is the same, making it look different is OK too.
  • For these, retry step 2 only. Retry could be implemented the same way as step 1 retry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants