Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Precision system #1140

Closed
chenkasirer opened this issue May 3, 2023 · 5 comments
Closed

Precision system #1140

chenkasirer opened this issue May 3, 2023 · 5 comments

Comments

@chenkasirer
Copy link
Member

Related to: #1057 (comment)

Some kind of a precision system can be useful which allows user to:

  • get/set a globally desired unit (mm/meter/cm etc.)
  • get/set a local version of the above
  • get/set the desired tolerance for each

This would replace all sorts of local tolerance which aren't standardized and are defined per module/class/instance.
Maybe in form of a Precision mixin which will by default fetch values from a global default and allow setting a modified local copy thereof.

@chenkasirer chenkasirer converted this from a draft issue May 3, 2023
@gonzalocasas
Copy link
Member

I always felt we needed to add built-in/native support for units across the board. Something like what astropy does: https://docs.astropy.org/en/stable/units/index.html

Because, well, it's important :)

Image

@jf---
Copy link
Contributor

jf--- commented Apr 6, 2024

@tomvanmele I think this can be closed with the Precision class being added in 2.0

@yck011522
Copy link
Contributor

@jf--- as far as I understand, the new Precision class solves the tolerance problem but did not really solve the lack of units problem that @gonzalocasas mentioned.

@jf---
Copy link
Contributor

jf--- commented Apr 7, 2024

Gotcha, thanks for pointing out. But that seems another issue altogether: precision and metric(s) and 2 separate issues of concern.

@gonzalocasas
Copy link
Member

Closing this and opened #1319 for the units idea/discussion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

4 participants