Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage secrets|configs.mode as an octal string||number #738

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ndeloof
Copy link
Collaborator

@ndeloof ndeloof commented Feb 13, 2025

A dedicated decoder is required for services.secrets.mode as octal value can be either yaml octal or a plain string

Closes moby/moby#49404

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not deeply familiar with the codebase, but looks solid, thanks!

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compose secrets does not set the correct mode
2 participants