mpdecimal: Fix cxx+shared, remove unnecessary automake dependency #25903
Conversation
Ahajha
changed the title
Ahajha
changed the title
yes please! |
Ahajha
changed the title
Ahajha
changed the title
| if not self.conf.get("tools.microsoft.bash:path", check_type=str): | ||
| self.tool_requires("msys2/cci.latest") | ||
| if not is_msvc(self) and self.settings_build.os == "Windows": | ||
| self.win_bash = True |
There was a problem hiding this comment.
given that our CI only covers win+msvc, I suppose this is an untested branch now.
Is this to support mingw?
Chances are that we need to detect clang and check if it it needs to fall outside of this conditional as well
There was a problem hiding this comment.
I believe I tested this branch with Mingw and it worked. I can play around with it, but regardless of if it works or not this should still be a strict improvement, because the only change is just removing the automake dependency, which definitely was not used.
There was a problem hiding this comment.
I'm actually not very familiar with what msys2 is used for in general. Is it just whenever we need access to a unix-style shell in a Windows build? So if we're calling commands like ls, sed, etc. (things that aren't available in Windows)?
This PR has 2 small but important fixes:
mpdecimal/*:shared=Trueandmpdecimal/*:cxx=True. This is a huge deal for the CPython recipe, since this will allow the Windows/all shared build to be valid again, and build in CI.I also have two other mpdecimal PRs out: #25889 (subset of this one) #25896