Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing tests for conda-lock install #411

Open
maresb opened this issue May 20, 2023 · 0 comments
Open

Add missing tests for conda-lock install #411

maresb opened this issue May 20, 2023 · 0 comments

Comments

@maresb
Copy link
Contributor

maresb commented May 20, 2023 •
edited
Loading

Merging #389, in particular 08f2292, broke conda-lock install because LockedDependency is a StrictModel, so removing optional means existing lockfiles which contain optional now have fields which are not permitted and lead to an error. CC @srilman

I merged #389 because all the tests were passing. We should have tests to detect when we can't install from the lockfiles we create.
This was referenced May 21, 2023
Merged
Open
@maresb maresb changed the title No changes to LockedDependency allowed without schema change Add missing tests for conda-lock install May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@maresb