Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

red teaming metrics are broken for conversation case #1381

Open
sermakarevich opened this issue Feb 23, 2025 · 1 comment
Open

red teaming metrics are broken for conversation case #1381

sermakarevich opened this issue Feb 23, 2025 · 1 comment

Comments

@sermakarevich
Copy link

❗BEFORE YOU BEGIN❗
Are you on discord? 🤗 We'd love to have you asking questions on discord instead: https://discord.com/invite/a3K9c8GRGt

Describe the bug

there are two issues in one place:

        if isinstance(test_case, ConversationalTestCase):
            test_case = check_conversational_test_case_params(test_case, self)
        check_llm_test_case_params(test_case, required_params, self)

while

def check_conversational_test_case_params(
    test_case: ConversationalTestCase,
    test_case_params: List[LLMTestCaseParams],
    metric: BaseConversationalMetric,
    require_chatbot_role: bool = False,
):
  1. check_conversational_test_case_params has 3 required params but passed 2
  2. check_conversational_test_case_params does not return anything, so test_case is None-ified if it is a ConversationalTestCase
@penguine-ip
Copy link
Contributor

@sermakarevich the red teaming metrics aren't meant to be used externally but if you make a PR happy to potentially incorperate it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants