feat(faithfulness): delegate template parameter for dynamic loading o… #1367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f FaithfulnessTemplate
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes a simple modification to the
FaithfulnessMetric classto support dynamic injection of theFaithfulnessTemplate. With this change, users can now inject their own domain-specific template (subclassed fromFaithfulnessTemplate) intoFaithfulnessMetric, allowing for more customized prompt generation based on the user's specific context.Motivation
Last month, I used DeepEval's faithfulness metrics and found that while the built-in algorithms work very well, I needed to override
_generate_claimsand_a_generate_claims...... to integratefew-shot promptconfigurations specific to my domain. I realized that by enabling dynamic injection of a customFaithfulnessTemplate, we can improve FaithfulnessMetric's adaptability across various domains without requiring a complete override of these methods.Thank you for taking the time to review my code and consider this PR.