Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run e2e tests for docker provider on CI #1946

Open
wainersm opened this issue Jul 24, 2024 · 3 comments · May be fixed by #1965
Open

Run e2e tests for docker provider on CI #1946

wainersm opened this issue Jul 24, 2024 · 3 comments · May be fixed by #1965
Assignees
@wainersm
Labels
CI Issues related to CI workflows

Comments

@wainersm
Copy link
Member

wainersm commented Jul 24, 2024 •
edited
Loading

Let's make the recent added e2e tests for docker running as part of CI (nightly and PR).

This way we will be able to test generic process-user-data as the libvirt CI doesn't cover that (libvirt uses cloud-init). Also if we managed to run with CRI-O, bonus points, as we don't have any CI for peer pods with CRI-O.

Depends on:

Cc @stevenhorsman @bpradipt
@wainersm wainersm added the CI Issues related to CI workflows label Jul 24, 2024
@wainersm wainersm self-assigned this Jul 24, 2024
@stevenhorsman
Copy link
Member

stevenhorsman commented Jul 25, 2024 •
edited
Loading

Given that the docker tests use the mkosi variant of the podvm image, I guess a pre-req for this to to try and get the mkosi image created regularly in the CI. Guess we could start with https://github.com/confidential-containers/cloud-api-adaptor/actions/workflows/podvm_mkosi_image.yaml and make it run on x86 as well as s390x?

That does look like the workflow is failing now, so I've raised #1949 to cover this.

@wainersm
Copy link
Member Author

Hi @stevenhorsman !

Given that the docker tests use the mkosi variant of the podvm image, I guess a pre-req for this to to try and get the mkosi image created regularly in the CI. Guess we could start with https://github.com/confidential-containers/cloud-api-adaptor/actions/workflows/podvm_mkosi_image.yaml and make it run on x86 as well as s390x?

That does look like the workflow is failing now, so I've raised #1949 to cover this.

I never ran the docker provider and so I had that doubt in my mind whether it uses the packer or mkosi variant. Thanks!

I can work on #1949 too if you don't want/cannot.

@stevenhorsman
Copy link
Member

I can work on #1949 too if you don't want/cannot.

Choi has worked out a fix, but it's to revert #1923, so it looks like there is some problem with running on ubuntu vs RHEL.

This was referenced Jul 31, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wainersm wainersm

Labels
CI Issues related to CI workflows
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CI: run e2e tests for docker provider wainersm/cc-cloud-api-adaptor
2 participants
@wainersm @stevenhorsman