Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent struct naming for secrets #633

Open
fitzthum opened this issue Jul 30, 2024 · 1 comment
Open

Inconsistent struct naming for secrets #633

fitzthum opened this issue Jul 30, 2024 · 1 comment

Comments

@fitzthum
Copy link
Member

fitzthum commented Jul 30, 2024

For envelope secrets we have a struct called Envelope that describes a secret. Meanwhile for vault secrets we have a struct called VaultSecret. Is there any reason why these two structs do not have the same naming (i.e. both including Secret or neither one)?

@Xynnn007
Copy link
Member

Oh, there might be some non-technical reasons. As we often use digital "envelope" to refer to such similar structure (a wrapped symmetric key inside the struct to encrypt the data), also a secret inside "vault" would be treated as "vault secret". During the naming I didnot think too much for this, but only try to describe their structure. I am ok to rename them if you have a better name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants