td-payload: decrypt private memory during allocation #664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Decrypt the private memory at initialization will leak the data of the linked list allocator. The solution can be moving decrytion to the moment the shared pages are allocated and encypting the shared memory before they are freed. Signed-off-by: Jiaqi Gao <[email protected]>
|
I am not sure why we need this. The expectation is that we pre-allocate a chunk of shared memory. |
The allocator Another solution can be using/realizing a bitmap allocator to put all the allocation information in the private memory |
|
Close as the allocator data of shared memory is not confidence |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decrypt the private memory at initialization will leak the data of the linked list allocator.
The solution can be moving decrytion to the moment the shared pages are allocated and encypting the shared memory before they are freed.
Closes: #662