From 269c224cc1cdf1e669c3b2663beff14efc3f19ff Mon Sep 17 00:00:00 2001 From: Robert Metzger Date: Tue, 17 Dec 2024 08:34:55 +0100 Subject: [PATCH] [hotfix] Fix 'delete' environment typo for CP Flink commands --- internal/flink/command_application_create.go | 2 +- internal/flink/command_application_describe.go | 2 +- internal/flink/command_application_list.go | 2 +- internal/flink/command_application_update.go | 2 +- internal/flink/command_application_webui.go | 2 +- .../fixtures/output/flink/application/create-help-onprem.golden | 2 +- test/fixtures/output/flink/application/create-help.golden | 2 +- .../output/flink/application/describe-help-onprem.golden | 2 +- test/fixtures/output/flink/application/describe-help.golden | 2 +- .../output/flink/application/describe-no-environment.golden | 2 +- .../output/flink/application/forward-negative-port.golden | 2 +- test/fixtures/output/flink/application/list-env-missing.golden | 2 +- test/fixtures/output/flink/application/list-help-onprem.golden | 2 +- test/fixtures/output/flink/application/list-help.golden | 2 +- .../fixtures/output/flink/application/update-help-onprem.golden | 2 +- test/fixtures/output/flink/application/update-help.golden | 2 +- .../output/flink/application/web-ui-forward-help-onprem.golden | 2 +- .../output/flink/application/web-ui-forward-help.golden | 2 +- 18 files changed, 18 insertions(+), 18 deletions(-) diff --git a/internal/flink/command_application_create.go b/internal/flink/command_application_create.go index de4f508eef..d7a3511574 100644 --- a/internal/flink/command_application_create.go +++ b/internal/flink/command_application_create.go @@ -24,7 +24,7 @@ func (c *command) newApplicationCreateCommand() *cobra.Command { RunE: c.applicationCreate, } - cmd.Flags().String("environment", "", "Name of the environment to delete the Flink application from.") + cmd.Flags().String("environment", "", "Name of the environment to create the Flink application from.") addCmfFlagSet(cmd) pcmd.AddOutputFlagWithHumanRestricted(cmd) diff --git a/internal/flink/command_application_describe.go b/internal/flink/command_application_describe.go index d05bc289b6..b949c31a5a 100644 --- a/internal/flink/command_application_describe.go +++ b/internal/flink/command_application_describe.go @@ -15,7 +15,7 @@ func (c *command) newApplicationDescribeCommand() *cobra.Command { RunE: c.applicationDescribe, } - cmd.Flags().String("environment", "", "Name of the environment to delete the Flink application from.") + cmd.Flags().String("environment", "", "Name of the environment to describe the Flink application from.") addCmfFlagSet(cmd) pcmd.AddOutputFlagWithHumanRestricted(cmd) diff --git a/internal/flink/command_application_list.go b/internal/flink/command_application_list.go index 9b695ee564..0f12e42073 100644 --- a/internal/flink/command_application_list.go +++ b/internal/flink/command_application_list.go @@ -15,7 +15,7 @@ func (c *command) newApplicationListCommand() *cobra.Command { RunE: c.applicationList, } - cmd.Flags().String("environment", "", "Name of the environment to delete the Flink application from.") + cmd.Flags().String("environment", "", "Name of the environment to list the Flink application from.") addCmfFlagSet(cmd) pcmd.AddOutputFlag(cmd) diff --git a/internal/flink/command_application_update.go b/internal/flink/command_application_update.go index 7777567218..179f7dd5e7 100644 --- a/internal/flink/command_application_update.go +++ b/internal/flink/command_application_update.go @@ -24,7 +24,7 @@ func (c *command) newApplicationUpdateCommand() *cobra.Command { RunE: c.applicationUpdate, } - cmd.Flags().String("environment", "", "Name of the environment to delete the Flink application from.") + cmd.Flags().String("environment", "", "Name of the environment to update the Flink application from.") addCmfFlagSet(cmd) pcmd.AddOutputFlagWithHumanRestricted(cmd) diff --git a/internal/flink/command_application_webui.go b/internal/flink/command_application_webui.go index f112899573..556d13f7a3 100644 --- a/internal/flink/command_application_webui.go +++ b/internal/flink/command_application_webui.go @@ -24,7 +24,7 @@ func (c *command) newApplicationWebUiForwardCommand() *cobra.Command { RunE: c.applicationWebUiForward, } - cmd.Flags().String("environment", "", "Name of the environment to delete the Flink application from.") + cmd.Flags().String("environment", "", "Name of the environment to forward the Flink application from.") addCmfFlagSet(cmd) cmd.Flags().Uint16("port", 0, "Port to forward the web UI to. If not provided, a random, OS-assigned port will be used.") diff --git a/test/fixtures/output/flink/application/create-help-onprem.golden b/test/fixtures/output/flink/application/create-help-onprem.golden index 0b20b1c2ee..a1edb53477 100644 --- a/test/fixtures/output/flink/application/create-help-onprem.golden +++ b/test/fixtures/output/flink/application/create-help-onprem.golden @@ -4,7 +4,7 @@ Usage: confluent flink application create [flags] Flags: - --environment string REQUIRED: Name of the environment to delete the Flink application from. + --environment string REQUIRED: Name of the environment to create the Flink application from. --url string Base URL of the Confluent Manager for Apache Flink (CMF). Environment variable "CONFLUENT_CMF_URL" may be set in place of this flag. --client-key-path string Path to client private key for mTLS authentication. Environment variable "CONFLUENT_CMF_CLIENT_KEY_PATH" may be set in place of this flag. --client-cert-path string Path to client cert to be verified by Confluent Manager for Apache Flink. Include for mTLS authentication. Environment variable "CONFLUENT_CMF_CLIENT_CERT_PATH" may be set in place of this flag. diff --git a/test/fixtures/output/flink/application/create-help.golden b/test/fixtures/output/flink/application/create-help.golden index 0b20b1c2ee..a1edb53477 100644 --- a/test/fixtures/output/flink/application/create-help.golden +++ b/test/fixtures/output/flink/application/create-help.golden @@ -4,7 +4,7 @@ Usage: confluent flink application create [flags] Flags: - --environment string REQUIRED: Name of the environment to delete the Flink application from. + --environment string REQUIRED: Name of the environment to create the Flink application from. --url string Base URL of the Confluent Manager for Apache Flink (CMF). Environment variable "CONFLUENT_CMF_URL" may be set in place of this flag. --client-key-path string Path to client private key for mTLS authentication. Environment variable "CONFLUENT_CMF_CLIENT_KEY_PATH" may be set in place of this flag. --client-cert-path string Path to client cert to be verified by Confluent Manager for Apache Flink. Include for mTLS authentication. Environment variable "CONFLUENT_CMF_CLIENT_CERT_PATH" may be set in place of this flag. diff --git a/test/fixtures/output/flink/application/describe-help-onprem.golden b/test/fixtures/output/flink/application/describe-help-onprem.golden index 16f076739b..841581bd44 100644 --- a/test/fixtures/output/flink/application/describe-help-onprem.golden +++ b/test/fixtures/output/flink/application/describe-help-onprem.golden @@ -4,7 +4,7 @@ Usage: confluent flink application describe [flags] Flags: - --environment string REQUIRED: Name of the environment to delete the Flink application from. + --environment string REQUIRED: Name of the environment to describe the Flink application from. --url string Base URL of the Confluent Manager for Apache Flink (CMF). Environment variable "CONFLUENT_CMF_URL" may be set in place of this flag. --client-key-path string Path to client private key for mTLS authentication. Environment variable "CONFLUENT_CMF_CLIENT_KEY_PATH" may be set in place of this flag. --client-cert-path string Path to client cert to be verified by Confluent Manager for Apache Flink. Include for mTLS authentication. Environment variable "CONFLUENT_CMF_CLIENT_CERT_PATH" may be set in place of this flag. diff --git a/test/fixtures/output/flink/application/describe-help.golden b/test/fixtures/output/flink/application/describe-help.golden index 16f076739b..841581bd44 100644 --- a/test/fixtures/output/flink/application/describe-help.golden +++ b/test/fixtures/output/flink/application/describe-help.golden @@ -4,7 +4,7 @@ Usage: confluent flink application describe [flags] Flags: - --environment string REQUIRED: Name of the environment to delete the Flink application from. + --environment string REQUIRED: Name of the environment to describe the Flink application from. --url string Base URL of the Confluent Manager for Apache Flink (CMF). Environment variable "CONFLUENT_CMF_URL" may be set in place of this flag. --client-key-path string Path to client private key for mTLS authentication. Environment variable "CONFLUENT_CMF_CLIENT_KEY_PATH" may be set in place of this flag. --client-cert-path string Path to client cert to be verified by Confluent Manager for Apache Flink. Include for mTLS authentication. Environment variable "CONFLUENT_CMF_CLIENT_CERT_PATH" may be set in place of this flag. diff --git a/test/fixtures/output/flink/application/describe-no-environment.golden b/test/fixtures/output/flink/application/describe-no-environment.golden index 570d4b2dec..bc10722b9d 100644 --- a/test/fixtures/output/flink/application/describe-no-environment.golden +++ b/test/fixtures/output/flink/application/describe-no-environment.golden @@ -3,7 +3,7 @@ Usage: confluent flink application describe [flags] Flags: - --environment string REQUIRED: Name of the environment to delete the Flink application from. + --environment string REQUIRED: Name of the environment to describe the Flink application from. --url string Base URL of the Confluent Manager for Apache Flink (CMF). Environment variable "CONFLUENT_CMF_URL" may be set in place of this flag. --client-key-path string Path to client private key for mTLS authentication. Environment variable "CONFLUENT_CMF_CLIENT_KEY_PATH" may be set in place of this flag. --client-cert-path string Path to client cert to be verified by Confluent Manager for Apache Flink. Include for mTLS authentication. Environment variable "CONFLUENT_CMF_CLIENT_CERT_PATH" may be set in place of this flag. diff --git a/test/fixtures/output/flink/application/forward-negative-port.golden b/test/fixtures/output/flink/application/forward-negative-port.golden index 8caad15a2d..499f1c030f 100644 --- a/test/fixtures/output/flink/application/forward-negative-port.golden +++ b/test/fixtures/output/flink/application/forward-negative-port.golden @@ -3,7 +3,7 @@ Usage: confluent flink application web-ui-forward [flags] Flags: - --environment string Name of the environment to delete the Flink application from. + --environment string Name of the environment to forward the Flink application from. --url string Base URL of the Confluent Manager for Apache Flink (CMF). Environment variable "CONFLUENT_CMF_URL" may be set in place of this flag. --client-key-path string Path to client private key for mTLS authentication. Environment variable "CONFLUENT_CMF_CLIENT_KEY_PATH" may be set in place of this flag. --client-cert-path string Path to client cert to be verified by Confluent Manager for Apache Flink. Include for mTLS authentication. Environment variable "CONFLUENT_CMF_CLIENT_CERT_PATH" may be set in place of this flag. diff --git a/test/fixtures/output/flink/application/list-env-missing.golden b/test/fixtures/output/flink/application/list-env-missing.golden index cca603d609..0b21ff3d08 100644 --- a/test/fixtures/output/flink/application/list-env-missing.golden +++ b/test/fixtures/output/flink/application/list-env-missing.golden @@ -3,7 +3,7 @@ Usage: confluent flink application list [flags] Flags: - --environment string REQUIRED: Name of the environment to delete the Flink application from. + --environment string REQUIRED: Name of the environment to list the Flink application from. --url string Base URL of the Confluent Manager for Apache Flink (CMF). Environment variable "CONFLUENT_CMF_URL" may be set in place of this flag. --client-key-path string Path to client private key for mTLS authentication. Environment variable "CONFLUENT_CMF_CLIENT_KEY_PATH" may be set in place of this flag. --client-cert-path string Path to client cert to be verified by Confluent Manager for Apache Flink. Include for mTLS authentication. Environment variable "CONFLUENT_CMF_CLIENT_CERT_PATH" may be set in place of this flag. diff --git a/test/fixtures/output/flink/application/list-help-onprem.golden b/test/fixtures/output/flink/application/list-help-onprem.golden index c167497e6e..6f855b8cfb 100644 --- a/test/fixtures/output/flink/application/list-help-onprem.golden +++ b/test/fixtures/output/flink/application/list-help-onprem.golden @@ -4,7 +4,7 @@ Usage: confluent flink application list [flags] Flags: - --environment string REQUIRED: Name of the environment to delete the Flink application from. + --environment string REQUIRED: Name of the environment to list the Flink application from. --url string Base URL of the Confluent Manager for Apache Flink (CMF). Environment variable "CONFLUENT_CMF_URL" may be set in place of this flag. --client-key-path string Path to client private key for mTLS authentication. Environment variable "CONFLUENT_CMF_CLIENT_KEY_PATH" may be set in place of this flag. --client-cert-path string Path to client cert to be verified by Confluent Manager for Apache Flink. Include for mTLS authentication. Environment variable "CONFLUENT_CMF_CLIENT_CERT_PATH" may be set in place of this flag. diff --git a/test/fixtures/output/flink/application/list-help.golden b/test/fixtures/output/flink/application/list-help.golden index c167497e6e..6f855b8cfb 100644 --- a/test/fixtures/output/flink/application/list-help.golden +++ b/test/fixtures/output/flink/application/list-help.golden @@ -4,7 +4,7 @@ Usage: confluent flink application list [flags] Flags: - --environment string REQUIRED: Name of the environment to delete the Flink application from. + --environment string REQUIRED: Name of the environment to list the Flink application from. --url string Base URL of the Confluent Manager for Apache Flink (CMF). Environment variable "CONFLUENT_CMF_URL" may be set in place of this flag. --client-key-path string Path to client private key for mTLS authentication. Environment variable "CONFLUENT_CMF_CLIENT_KEY_PATH" may be set in place of this flag. --client-cert-path string Path to client cert to be verified by Confluent Manager for Apache Flink. Include for mTLS authentication. Environment variable "CONFLUENT_CMF_CLIENT_CERT_PATH" may be set in place of this flag. diff --git a/test/fixtures/output/flink/application/update-help-onprem.golden b/test/fixtures/output/flink/application/update-help-onprem.golden index fc1d159bd6..e20807230c 100644 --- a/test/fixtures/output/flink/application/update-help-onprem.golden +++ b/test/fixtures/output/flink/application/update-help-onprem.golden @@ -4,7 +4,7 @@ Usage: confluent flink application update [flags] Flags: - --environment string REQUIRED: Name of the environment to delete the Flink application from. + --environment string REQUIRED: Name of the environment to update the Flink application from. --url string Base URL of the Confluent Manager for Apache Flink (CMF). Environment variable "CONFLUENT_CMF_URL" may be set in place of this flag. --client-key-path string Path to client private key for mTLS authentication. Environment variable "CONFLUENT_CMF_CLIENT_KEY_PATH" may be set in place of this flag. --client-cert-path string Path to client cert to be verified by Confluent Manager for Apache Flink. Include for mTLS authentication. Environment variable "CONFLUENT_CMF_CLIENT_CERT_PATH" may be set in place of this flag. diff --git a/test/fixtures/output/flink/application/update-help.golden b/test/fixtures/output/flink/application/update-help.golden index fc1d159bd6..e20807230c 100644 --- a/test/fixtures/output/flink/application/update-help.golden +++ b/test/fixtures/output/flink/application/update-help.golden @@ -4,7 +4,7 @@ Usage: confluent flink application update [flags] Flags: - --environment string REQUIRED: Name of the environment to delete the Flink application from. + --environment string REQUIRED: Name of the environment to update the Flink application from. --url string Base URL of the Confluent Manager for Apache Flink (CMF). Environment variable "CONFLUENT_CMF_URL" may be set in place of this flag. --client-key-path string Path to client private key for mTLS authentication. Environment variable "CONFLUENT_CMF_CLIENT_KEY_PATH" may be set in place of this flag. --client-cert-path string Path to client cert to be verified by Confluent Manager for Apache Flink. Include for mTLS authentication. Environment variable "CONFLUENT_CMF_CLIENT_CERT_PATH" may be set in place of this flag. diff --git a/test/fixtures/output/flink/application/web-ui-forward-help-onprem.golden b/test/fixtures/output/flink/application/web-ui-forward-help-onprem.golden index 0d56f1d088..8174d2cc23 100644 --- a/test/fixtures/output/flink/application/web-ui-forward-help-onprem.golden +++ b/test/fixtures/output/flink/application/web-ui-forward-help-onprem.golden @@ -4,7 +4,7 @@ Usage: confluent flink application web-ui-forward [flags] Flags: - --environment string REQUIRED: Name of the environment to delete the Flink application from. + --environment string REQUIRED: Name of the environment to forward the Flink application from. --url string Base URL of the Confluent Manager for Apache Flink (CMF). Environment variable "CONFLUENT_CMF_URL" may be set in place of this flag. --client-key-path string Path to client private key for mTLS authentication. Environment variable "CONFLUENT_CMF_CLIENT_KEY_PATH" may be set in place of this flag. --client-cert-path string Path to client cert to be verified by Confluent Manager for Apache Flink. Include for mTLS authentication. Environment variable "CONFLUENT_CMF_CLIENT_CERT_PATH" may be set in place of this flag. diff --git a/test/fixtures/output/flink/application/web-ui-forward-help.golden b/test/fixtures/output/flink/application/web-ui-forward-help.golden index 0d56f1d088..8174d2cc23 100644 --- a/test/fixtures/output/flink/application/web-ui-forward-help.golden +++ b/test/fixtures/output/flink/application/web-ui-forward-help.golden @@ -4,7 +4,7 @@ Usage: confluent flink application web-ui-forward [flags] Flags: - --environment string REQUIRED: Name of the environment to delete the Flink application from. + --environment string REQUIRED: Name of the environment to forward the Flink application from. --url string Base URL of the Confluent Manager for Apache Flink (CMF). Environment variable "CONFLUENT_CMF_URL" may be set in place of this flag. --client-key-path string Path to client private key for mTLS authentication. Environment variable "CONFLUENT_CMF_CLIENT_KEY_PATH" may be set in place of this flag. --client-cert-path string Path to client cert to be verified by Confluent Manager for Apache Flink. Include for mTLS authentication. Environment variable "CONFLUENT_CMF_CLIENT_CERT_PATH" may be set in place of this flag.