Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

background thread service: propagate exceptions when stopped #102

Open
granders opened this issue Sep 22, 2015 · 0 comments
Open

background thread service: propagate exceptions when stopped #102

granders opened this issue Sep 22, 2015 · 0 comments

Comments

@granders
Copy link
Contributor

Exceptions are propagated from the background thread in BackgroundThreadService.wait, but not in stop.

If a background thread service is started and then stopped without waiting, exceptions from the thread won't be made visible.
fpj added a commit that referenced this issue Oct 1, 2015
@fpj @guozhangwang
KAFKA-2300: Error in controller log when broker tries to rejoin cluster
a62d630 
Author: flavio junqueira <[email protected]>

Reviewers: Ismael Juma, Guozhang Wang

Closes #102 from fpj/2300 and squashes the following commits:

7bd2edb [flavio junqueira] KAFKA-2300: Removed unnecessary s" occurrences.
aa6ec90 [flavio junqueira] KAFKA-2300: Wrapped all occurences of sendRequestToBrokers with try/catch and fixed string typo.
f1261b1 [flavio junqueira] Fixed some style issues.
9b6390a [flavio junqueira] Updated package name and removed unnecessary imports.
dbd1bf3 [flavio junqueira] KAFKA-2300: Error in controller log when broker tries to rejoin cluster
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@granders