Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

html report generation broken #223

Open
jspong opened this issue Mar 27, 2020 · 0 comments
Open

html report generation broken #223

jspong opened this issue Mar 27, 2020 · 0 comments

Comments

@jspong
Copy link
Contributor

jspong commented Mar 27, 2020

In adding python 3 support, ducktape/templates/report/report.html was updated use {{ }} for variable interpolation instead of %s.

React fails to render the html report with the following error:

Uncaught Error: Parse Error: Line 162: Unexpected token {
    at http://confluent-platform-branch-builder-system-test-results.s3-us-west-2.amazonaws.com/2020-03-25--002.1585183175--jspong--HEAD--04b96f8/report.html

"tests": {{num_tests}},
         ^
    at throwError (https://unpkg.com/[email protected]/dist/JSXTransformer.js:5119:21)
    at throwUnexpected (https://unpkg.com/[email protected]/dist/JSXTransformer.js:5181:9)
    at parseObjectProperty (https://unpkg.com/[email protected]/dist/JSXTransformer.js:5621:17)
    at parseObjectInitialiser (https://unpkg.com/[email protected]/dist/JSXTransformer.js:5697:28)
    at parsePrimaryExpression (https://unpkg.com/[email protected]/dist/JSXTransformer.js:5864:20)
    at parseLeftHandSideExpressionAllowCall (https://unpkg.com/[email protected]/dist/JSXTransformer.js:5967:61)
    at parsePostfixExpression (https://unpkg.com/[email protected]/dist/JSXTransformer.js:6007:20)
    at parseUnaryExpression (https://unpkg.com/[email protected]/dist/JSXTransformer.js:6074:16)
    at parseBinaryExpression (https://unpkg.com/[email protected]/dist/JSXTransformer.js:6164:16)
    at parseConditionalExpression (https://unpkg.com/[email protected]/dist/JSXTransformer.js:6224:16)

We can pretty easily update ducktape/tests/reporter.py to treat this as a Jinja2 template and interpolate the values properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant