Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow tests to specify files to be downloaded and included in output #91

Open
ewencp opened this issue Aug 27, 2015 · 0 comments
Open

Allow tests to specify files to be downloaded and included in output #91

ewencp opened this issue Aug 27, 2015 · 0 comments

Comments

@ewencp
Copy link
Contributor

ewencp commented Aug 27, 2015

We can specify fixed log files for a service that should or should not be downloaded, but sometimes there are other files involved in tests that are defined dynamically and the service isn't directly aware of. For example, the Copycat tests echo to an input file, and then the sink Copycat worker write its output to another file. But the Copycat service never knows about these files directly since they are specified in the connector configuration.

It would be helpful for tests to somehow be able to specify additional files (per service) that should be downloaded when the test completes. This would, for example, help debug what is going wrong when the test fails since the two files are supposed to be identical.
guozhangwang pushed a commit that referenced this issue Oct 1, 2015
@sslavic @guozhangwang
MINOR: auto.offset.reset docs not in sync with validation
4b798f0 
In this commit apache/kafka@0699ff2#diff-5533ddc72176acd1c32f5abbe94aa672 among other things auto.offset.reset possible options were changed from smallest to earliest and from largest to latest, but not in documentation for that configuration property.

This patch fixes documentation for auto.offset.reset consumer configuration property so it is in sync with validation logic.

Author: Stevo Slavić <[email protected]>

Reviewers: Jason, Ismael, Guozhang

Closes #91 from sslavic/patch-5 and squashes the following commits:

f4c9656 [Stevo Slavić] MINOR: auto.offset.reset docs not in sync with validation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ewencp