Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there a fork that's maintained? #42

Open
Boscop opened this issue Sep 30, 2019 · 6 comments
Open

Is there a fork that's maintained? #42

Boscop opened this issue Sep 30, 2019 · 6 comments

Comments

@Boscop
Copy link

Boscop commented Sep 30, 2019

I would like to add the methods get_or_insert and get_or_insert_with, but this crate won't accept PRs it says. Is there a more maintained fork?

@clarfonthey
Copy link
Contributor

I believe that the orignal maintainer was looking for folks to pick up contain-rs instead of just putting it into maintenance mode. Unfortunately, no one took up the offer.

Not sure if the offer is still open, though.

@camsteffen
Copy link
Contributor

I would like to add the methods get_or_insert and get_or_insert_with

Use the Entry API.

Is there a more maintained fork?

The message on the readme seems like it is written to scare people away from using this crate. But my impression is that there isn't a lot of room for improvement for VecMap and this is still perfectly fine to use. And I think that is why there isn't a replacement rising up in the rust community.

@clarfonthey
Copy link
Contributor

Honestly, I disagree-- there are definitely new APIs that have been made since the library was put up and you always want to make sure someone can maintain it.

No one really stepped up when Gankra didn't have any more bandwidth to maintain collect-rs but I feel like it could definitely use the love, if folks had love to provide.

@camsteffen
Copy link
Contributor

camsteffen commented Jun 30, 2020

there are definitely new APIs that have been made since the library was put up

Would you mind sharing some of those? I haven't been able to find a viable replacement for VecMap.

No one really stepped up when Gankra didn't have any more bandwidth to maintain collect-rs but I feel like it could definitely use the love, if folks had love to provide.

That's sad to hear. I'm not really aware of that history. But I don't see any invitation for maintainers.

Do you think VecMap could "use the love" specifically or are you referring to collect-rs in general? Do you have specific improvements in mind?

@clarfonthey
Copy link
Contributor

By new APIs I mean, new things that are added to other maps that might make sense to add to this one. Also, collect-rs in general could use some love, but I feel that folks who have the time, resources, and desire to maintain these should step up. They're already being replaced by other libraries.

@Boscop
Copy link
Author

Boscop commented Jul 3, 2020

@clarfon By which other libraries?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants