-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make mode
optional?
#48
Comments
Fields in proto3 cannot be optional. Mode is required. Is there a use case for not specifying the file mode? |
My intent was for the root dir issue discussed in https://github.com/docker/containerd/issues/523, but on second thought I found that the However, for |
Could you clarify that request in another issue? |
sure, opened #49 |
https://github.com/stevvooe/continuity/blob/master/proto/manifest.proto
Since
mode
is currently defined asuint32
, there is no way to omitmode
from the manifest(zero should be interpreted as zero, not nil)
Or maybe it should bbetter to clarify that
mode
is mandatory field and cannot be omitted, but I'm not sure it causes compatibility issueThe text was updated successfully, but these errors were encountered: