Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make mode optional? #48

Closed
AkihiroSuda opened this issue Feb 15, 2017 · 4 comments
Closed

Make mode optional? #48

AkihiroSuda opened this issue Feb 15, 2017 · 4 comments

Comments

@AkihiroSuda
Copy link
Member

AkihiroSuda commented Feb 15, 2017

https://github.com/stevvooe/continuity/blob/master/proto/manifest.proto

Since mode is currently defined as uint32, there is no way to omit mode from the manifest
(zero should be interpreted as zero, not nil)

Or maybe it should bbetter to clarify that mode is mandatory field and cannot be omitted, but I'm not sure it causes compatibility issue

@stevvooe
Copy link
Member

Fields in proto3 cannot be optional. Mode is required.

Is there a use case for not specifying the file mode?

@AkihiroSuda
Copy link
Member Author

My intent was for the root dir issue discussed in https://github.com/docker/containerd/issues/523, but on second thought I found that the ModeDir bit is still required.
So I'm closing this issue.

However, for context.Verify(), I think we still need some umask-like feature for the issue mentioned above and for non-UNIX filesystems such as FAT.

@stevvooe
Copy link
Member

However, for context.Verify(), I think we still need some umask-like feature for the issue mentioned above and for non-UNIX filesystems such as FAT.

Could you clarify that request in another issue?

@AkihiroSuda
Copy link
Member Author

sure, opened #49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants