Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MODEL_ENDPOINT hard coded for Makefile run command #561

Open
HunterGerlach opened this issue Jun 13, 2024 · 0 comments
Open

MODEL_ENDPOINT hard coded for Makefile run command #561

HunterGerlach opened this issue Jun 13, 2024 · 0 comments
Labels
enhancement Improve on an existing feature or experience

Comments

@HunterGerlach
Copy link

When attempting to modify the MODEL_ENDPOINT in the Chatbot recipe's playbook.yml to point to an externally deployed model, I was unable to get the new endpoint to be used.

I expected to simply save the endpoint change in VSCode and refresh the recipe deployment and interact with the new endpoint.

I traced this issue down to hard coded values in the commonMakefile.common file:

https://github.com/containers/ai-lab-recipes/blob/main/recipes/common/Makefile.common#L190

@cooktheryan cooktheryan added the enhancement Improve on an existing feature or experience label Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve on an existing feature or experience
Projects
None yet
Development

No branches or pull requests

2 participants