Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in multicolumnwizard_be.js #74

Closed
theDyingMountain opened this issue Mar 18, 2020 · 5 comments
Closed

Typo in multicolumnwizard_be.js #74

theDyingMountain opened this issue Mar 18, 2020 · 5 comments
Assignees
@stefanheimes
Labels
bug Something isn't working
Milestone
3.4.x

Comments

@theDyingMountain
Copy link

theDyingMountain commented Mar 18, 2020 •
edited by zonky2
Loading

In addOperationUpdateCallback() wird fälschlicherweise this.operationLoadCallbacks verwendet.

Siehe:
https://github.com/menatwork/contao-multicolumnwizard-bundle/blob/master/src/Resources/public/js/multicolumnwizard_be.js#L364

        addOperationUpdateCallback: function(key, func)
                                    {
                                        if (!this.operationUpdateCallbacks[key])
                                        {
                                            this.operationUpdateCallbacks[key] = [];
                                        }

-                                        this.operationLoadCallbacks[key].include(func);
+                                        ?;
                                    },
@zonky2
Copy link
Contributor

zonky2 commented Mar 18, 2020

stattdessen? bitte PR machen oder code posten mit "diff" sowie "-" und "+"

@zonky2 zonky2 added the bug Something isn't working label Mar 18, 2020
@zonky2 zonky2 added this to the 3.4.5 milestone Mar 18, 2020
@theDyingMountain
Copy link
Author 

        addOperationUpdateCallback: function(key, func)
                                    {
                                        if (!this.operationUpdateCallbacks[key])
                                        {
                                            this.operationUpdateCallbacks[key] = [];
                                        }

-                                        this.operationLoadCallbacks[key].include(func);
+                                        this.operationUpdateCallbacks[key].include(func);

@zonky2
Copy link
Contributor

zonky2 commented Mar 19, 2020

damit ist es zu einem PR ja nicht mehr weit :D

@theDyingMountain
Copy link
Author

erledigt in PR #75

@zonky2 zonky2 modified the milestones: 3.4.5, 3.4.x Sep 9, 2020
zonky2 added a commit to zonky2/contao-multicolumnwizard-bundle that referenced this issue Sep 10, 2020
@zonky2
Hotfix fix typo in js
e876a64 
Issue contao-community-alliance#74
@zonky2 zonky2 mentioned this issue Sep 10, 2020
Merged
stefanheimes added a commit that referenced this issue Sep 18, 2020
@stefanheimes
Merge PR #88 from @zonky2
f08c17c 
Hotfix fix typo in js
See issue #74
Replacement for PR #75
stefanheimes added a commit that referenced this issue Sep 20, 2020
@stefanheimes
Merge tag '3.4.7' into Master
e9c6623 
- Add support for Sortable.js for https://github.com/contao-community-alliance/contao-multicolumnwizard-frontend-bundle
- Hotfix fix typo in js. See issue #74, Replacement for PR #75
- Correct some travis setting: Correct exclude path, Update PHP and Contao Version
- Correct some small errors for the travis check
@zonky2
Copy link
Contributor

zonky2 commented Aug 29, 2021

fixed https://github.com/menatwork/contao-multicolumnwizard-bundle/pull/88

@zonky2 zonky2 closed this as completed Aug 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stefanheimes stefanheimes

Labels
bug Something isn't working
Projects
None yet
Milestone
3.4.x
Development

No branches or pull requests
3 participants
@stefanheimes @zonky2 @theDyingMountain