[RTM] Makes the execute post actions compatible for the dcg #92
Conversation
baumannsven
changed the title
baumannsven
force-pushed
the
hotfix/dcg_execute_post_action
branch
from
235ea7c to
4c34402
Compare
|
Travis build is failing. After the test build works fine, i switch the label wip => rtm. |
zonky2
changed the title
baumannsven
force-pushed
the
hotfix/dcg_execute_post_action
branch
2 times, most recently
from
37958b2 to
21cc2df
Compare
|
@discordier I have add the two dcg packages to require-dev section. So after adds the package, the travis build crashes. I have no idea, what I can do. Can you please take a look at this? |
| @@ -28,20 +28,23 @@ matrix: | |||
| allow_failures: | |||
| - env: CONTAO_VERSION=~4.10.0 | |||
|
|
|||
| before_script: | |||
| - echo "memory_limit=-1" >> ~/.phpenv/versions/$(phpenv version-name)/etc/conf.d/travis.ini | |||
| sudo: false | |||
There was a problem hiding this comment.
Not needed anymore. See https://docs.travis-ci.com/user/reference/overview/#deprecated-virtualization-environments
There was a problem hiding this comment.
Not working. I not remove this line.
https://travis-ci.org/github/menatwork/contao-multicolumnwizard-bundle/jobs/742631080
There was a problem hiding this comment.
What do you mean by not working? Sudo is not needed anymore... I removed it from many .travis.yml files already.
There was a problem hiding this comment.
Oh sorry. I think do you mean the before script setting
.travis.yml
Outdated
| - travis_retry composer self-update && composer --version | ||
| - travis_retry composer require contao/core-bundle $CONTAO_VERSION --no-update | ||
| - > | ||
| if [ "x${TRAVIS_TAG}" != "x" ]; then | ||
| export COMPOSER_ROOT_VERSION=${TRAVIS_TAG} |
There was a problem hiding this comment.
Please revert this, exporting and echoing below helps pin point problems as this PR is currently having.
We now have no clue at all what composer thinks it has installed as root package and therefore do not know how to make it install dcg.
composer.json
Outdated
| @@ -55,12 +55,14 @@ | |||
| }, | |||
| "require": { | |||
| "php": "^5.6 || ^7.0", | |||
| "contao/core-bundle": "^4.4.8", | |||
| "contao/core-bundle": "~4.4.0", | |||
There was a problem hiding this comment.
Why the downgrade to 4.4.0? AFAIR we upgraded to at least 4.4.8 for a reason (some bug that was incompatible with this extension).
There was a problem hiding this comment.
baumannsven
force-pushed
the
hotfix/dcg_execute_post_action
branch
7 times, most recently
from
99063d5 to
1497160
Compare
…le tree widget is working now with the dcg.
baumannsven
force-pushed
the
hotfix/dcg_execute_post_action
branch
from
1497160 to
cd33adc
Compare
|
@stefanheimes I temporarily removed the two necessary development packages from DC General, so we called by phone. These will be added again later. |
This is the fix for can use e.g. file tree widget with the dcg.