Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for string constants in Workshop #56

Open
ct2034 opened this issue Oct 8, 2024 · 1 comment
Open

Support for string constants in Workshop #56

ct2034 opened this issue Oct 8, 2024 · 1 comment
Labels
feature New feature or request priority: middle

Comments

@ct2034
Copy link
Member

ct2034 commented Oct 8, 2024

  • preprocessing step that looks through the bt.xml and all scxmls for string constants
  • fixed mapping between strings constants and unique integers (like a enum)
  • replace strings with corresponding numbers in bt.xml and scxmls

e.g.
(in bt.xml)

<DetectObject name="DetectSnack" object="snacks0"/>

turns into ...

<DetectObject name="DetectSnack" object="8"/>

and
(in scxml)

<field name="data" expr="_msg.data == 'snacks0'" />

turns into ...

<field name="data" expr="_msg.data == 8" />
@MarcoLm993
Copy link
Collaborator

The workshop survived without this feature, so we can now relax and postpone this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request priority: middle
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants